Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: chrome/browser/devtools/devtools_ui_bindings.cc

Issue 2384343002: DevTools: improve DevTools file watcher to send added and removed paths (Closed)
Patch Set: go above and beyond Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/devtools_ui_bindings.cc
diff --git a/chrome/browser/devtools/devtools_ui_bindings.cc b/chrome/browser/devtools/devtools_ui_bindings.cc
index fd0690afd29cde123e98efa4e6caaaeb814999cc..9f8db2ee84647b6753f8d802f9b91b55a00ebc07 100644
--- a/chrome/browser/devtools/devtools_ui_bindings.cc
+++ b/chrome/browser/devtools/devtools_ui_bindings.cc
@@ -977,12 +977,19 @@ void DevToolsUIBindings::FileSystemRemoved(
}
void DevToolsUIBindings::FilePathsChanged(
- const std::vector<std::string>& file_paths) {
- base::ListValue list;
- for (auto path : file_paths)
- list.AppendString(path);
- CallClientFunction("DevToolsAPI.fileSystemFilesChanged",
- &list, NULL, NULL);
+ const std::vector<std::string>& changed_paths,
+ const std::vector<std::string>& added_paths,
+ const std::vector<std::string>& removed_paths) {
+ base::ListValue added, changed, removed;
+ for (auto path : changed_paths)
+ changed.AppendString(path);
+ for (auto path : added_paths)
+ added.AppendString(path);
+ for (auto path : removed_paths)
+ removed.AppendString(path);
+
+ CallClientFunction("DevToolsAPI.fileSystemFilesChanged", &changed, &added,
dgozman 2016/10/04 02:26:41 Let's pass single parameter here and not change de
lushnikov 2016/10/04 02:51:59 Done.
+ &removed);
}
void DevToolsUIBindings::IndexingTotalWorkCalculated(

Powered by Google App Engine
This is Rietveld 408576698