DevTools: improve DevTools file watcher to send added and removed paths

chrome/browser/devtools/devtools_ui_bindings.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/devtools/devtools_ui_bindings.h"
 
 #include <stddef.h>
 
 #include <memory>
 #include <utility>
@@ skipping 959 matching lines @@
 }
 
 void DevToolsUIBindings::FileSystemRemoved(
     const std::string& file_system_path) {
   base::StringValue file_system_path_value(file_system_path);
   CallClientFunction("DevToolsAPI.fileSystemRemoved",
                      &file_system_path_value, NULL, NULL);
 }
 
 void DevToolsUIBindings::FilePathsChanged(
-    const std::vector<std::string>& file_paths) {
-  base::ListValue list;
-  for (auto path : file_paths)
-    list.AppendString(path);
-  CallClientFunction("DevToolsAPI.fileSystemFilesChanged",
-                     &list, NULL, NULL);
+    const std::vector<std::string>& changed_paths,
+    const std::vector<std::string>& added_paths,
+    const std::vector<std::string>& removed_paths) {
+  base::ListValue added, changed, removed;
+  for (auto path : changed_paths)
+    changed.AppendString(path);
+  for (auto path : added_paths)
+    added.AppendString(path);
+  for (auto path : removed_paths)
+    removed.AppendString(path);
+
+  CallClientFunction("DevToolsAPI.fileSystemFilesChanged", &changed, &added,

[dgozman, 2016/10/04 02:26:41]

Let's pass single parameter here and not change devtools.js.

[lushnikov, 2016/10/04 02:51:59]

Done.

+                     &removed);
 }
 
 void DevToolsUIBindings::IndexingTotalWorkCalculated(
     int request_id,
     const std::string& file_system_path,
     int total_work) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
   base::FundamentalValue request_id_value(request_id);
   base::StringValue file_system_path_value(file_system_path);
   base::FundamentalValue total_work_value(total_work);
@@ skipping 165 matching lines @@
 void DevToolsUIBindings::FrontendLoaded() {
   if (frontend_loaded_)
     return;
   frontend_loaded_ = true;
 
   // Call delegate first - it seeds importants bit of information.
   delegate_->OnLoadCompleted();
 
   AddDevToolsExtensionsToClient();
 }