Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Unified Diff: third_party/WebKit/Source/devtools/front_end/workspace/IsolatedFileSystemManager.js

Issue 2384343002: DevTools: improve DevTools file watcher to send added and removed paths (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/workspace/IsolatedFileSystemManager.js
diff --git a/third_party/WebKit/Source/devtools/front_end/workspace/IsolatedFileSystemManager.js b/third_party/WebKit/Source/devtools/front_end/workspace/IsolatedFileSystemManager.js
index dc96332bc759c1a21643cc7b2eec12eb867ee721..bd2d4e757075938585d302ff2857fac8af1d124b 100644
--- a/third_party/WebKit/Source/devtools/front_end/workspace/IsolatedFileSystemManager.js
+++ b/third_party/WebKit/Source/devtools/front_end/workspace/IsolatedFileSystemManager.js
@@ -34,6 +34,8 @@
*/
WebInspector.IsolatedFileSystemManager = function()
{
+ WebInspector.Object.call(this);
dgozman 2016/10/04 00:17:02 Whoa!
+
/** @type {!Map<string, !WebInspector.IsolatedFileSystem>} */
this._fileSystems = new Map();
/** @type {!Map<number, function(!Array.<string>)>} */
@@ -199,8 +201,10 @@ WebInspector.IsolatedFileSystemManager.prototype = {
*/
_onFileSystemFilesChanged: function(event)
{
- var embedderPaths = /** @type {!Array<string>} */ (event.data);
- var paths = embedderPaths.map(embedderPath => WebInspector.IsolatedFileSystemManager.normalizePath(embedderPath));
+ var changedPaths = /** @type {!Array<string>} */ (event.data["changedPaths"]).map(WebInspector.IsolatedFileSystemManager.normalizePath);
+ var addedPaths = /** @type {!Array<string>} */ (event.data["addedPaths"]).map(WebInspector.IsolatedFileSystemManager.normalizePath);
+ var removedPaths = /** @type {!Array<string>} */ (event.data["removedPaths"]).map(WebInspector.IsolatedFileSystemManager.normalizePath);
+ var paths = changedPaths.concat(addedPaths, removedPaths);
dgozman 2016/10/04 00:17:02 Let's use it in the same patch?
lushnikov 2016/10/04 01:04:19 Reverted this.
this.dispatchEventToListeners(WebInspector.IsolatedFileSystemManager.Events.FileSystemFilesChanged, paths);
},

Powered by Google App Engine
This is Rietveld 408576698