Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Unified Diff: third_party/WebKit/Source/devtools/front_end/devtools.js

Issue 2384343002: DevTools: improve DevTools file watcher to send added and removed paths (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/devtools.js
diff --git a/third_party/WebKit/Source/devtools/front_end/devtools.js b/third_party/WebKit/Source/devtools/front_end/devtools.js
index a56b6486b488e0d7f7db73a71e1a00d5af838bcd..ebf3f82344fa074636cc24af0d8438c56a1254db 100644
--- a/third_party/WebKit/Source/devtools/front_end/devtools.js
+++ b/third_party/WebKit/Source/devtools/front_end/devtools.js
@@ -194,9 +194,9 @@ DevToolsAPIImpl.prototype = {
this._dispatchOnInspectorFrontendAPI("fileSystemAdded", ["", fileSystem]);
},
- fileSystemFilesChanged: function(path)
+ fileSystemFilesChanged: function(changedPaths, addedPaths, removedPaths)
dgozman 2016/10/04 00:17:02 Let's add JSDoc.
lushnikov 2016/10/04 01:04:18 Done.
{
- this._dispatchOnInspectorFrontendAPI("fileSystemFilesChanged", [path]);
+ this._dispatchOnInspectorFrontendAPI("fileSystemFilesChanged", [changedPaths, addedPaths, removedPaths]);
dgozman 2016/10/04 00:17:02 I'd rename the method to fileSystemPathsChanged to
lushnikov 2016/10/04 01:04:18 Nice, thanks! As per offline discussion, I've ref
},
/**

Powered by Google App Engine
This is Rietveld 408576698