third_party/WebKit/LayoutTests/http/tests/inspector/isolated-filesystem-test.js - Issue 2384343002: DevTools: improve DevTools file watcher to send added and removed paths

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/isolated-filesystem-test.js

Issue 2384343002: DevTools: improve DevTools file watcher to send added and removed paths (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/devtools/devtools_file_watcher.cc ('K') | « chrome/browser/devtools/devtools_ui_bindings.cc ('k') | third_party/WebKit/LayoutTests/inspector/file-system-project.html » ('j') | third_party/WebKit/Source/devtools/front_end/devtools.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/isolated-filesystem-test.js

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/isolated-filesystem-test.js b/third_party/WebKit/LayoutTests/http/tests/inspector/isolated-filesystem-test.js

index 5d0ed1ab79f1e57e526b4cf5c754b58ccea8a2b1..8f0083554b13aec4b3a18b19c6debf21d1886299 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/isolated-filesystem-test.js

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/isolated-filesystem-test.js

@@ -83,7 +83,7 @@ InspectorTest.TestFileSystem.Entry.prototype = {

this._children.splice(index, 1);

delete this._childrenMap[child.name];

child.parent = null;

- InspectorFrontendHost.events.dispatchEventToListeners(InspectorFrontendHostAPI.Events.FileSystemFilesChanged, [fullPath]);

+ InspectorFrontendHost.events.dispatchEventToListeners(InspectorFrontendHostAPI.Events.FileSystemFilesChanged, {changedPaths: [], removedPaths: [fullPath], addedPaths: []});

success();

@@ -110,7 +110,7 @@ InspectorTest.TestFileSystem.Entry.prototype = {

{

this.content = new Blob([content], {type: 'text/plain'});

var fullPath = this._fileSystem.fileSystemPath + this.fullPath;

- InspectorFrontendHost.events.dispatchEventToListeners(InspectorFrontendHostAPI.Events.FileSystemFilesChanged, [fullPath]);

+ InspectorFrontendHost.events.dispatchEventToListeners(InspectorFrontendHostAPI.Events.FileSystemFilesChanged, {changedPaths: [fullPath], removedPaths: [], addedPaths: []});

createReader: function()