Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 2384273004: [Sensors] 'onerror' event implementation (Closed)

Created:
4 years, 2 months ago by Mikhail
Modified:
4 years, 2 months ago
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sensors] 'onerror' event implementation This CL introduces sensor 'onerror' event and layout tests. BUG=606766 Committed: https://crrev.com/e78cbef6bacd2a34b4fd258fd874e8b0a2db6dc3 Cr-Commit-Position: refs/heads/master@{#423198}

Patch Set 1 #

Patch Set 2 : updated global-interface-listing-expected.txt #

Messages

Total messages: 25 (19 generated)
Mikhail
please take a look
4 years, 2 months ago (2016-10-04 12:59:13 UTC) #10
haraken
LGTM on my side
4 years, 2 months ago (2016-10-04 14:57:49 UTC) #13
shalamov
lgtm
4 years, 2 months ago (2016-10-05 06:21:32 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384273004/40001
4 years, 2 months ago (2016-10-05 14:48:00 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 2 months ago (2016-10-05 17:12:52 UTC) #23
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 17:16:32 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e78cbef6bacd2a34b4fd258fd874e8b0a2db6dc3
Cr-Commit-Position: refs/heads/master@{#423198}

Powered by Google App Engine
This is Rietveld 408576698