Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Unified Diff: third_party/WebKit/Source/modules/sensor/SensorProxy.h

Issue 2384273004: [Sensors] 'onerror' event implementation (Closed)
Patch Set: updated global-interface-listing-expected.txt Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/sensor/SensorProxy.h
diff --git a/third_party/WebKit/Source/modules/sensor/SensorProxy.h b/third_party/WebKit/Source/modules/sensor/SensorProxy.h
index 9e41bd3a56bb3ccf5cfecc56dc02410bf4f824f2..70c87a2f15b4b5e194ef350aa14f311c55b13fa3 100644
--- a/third_party/WebKit/Source/modules/sensor/SensorProxy.h
+++ b/third_party/WebKit/Source/modules/sensor/SensorProxy.h
@@ -5,6 +5,7 @@
#ifndef SensorProxy_h
#define SensorProxy_h
+#include "core/dom/ExceptionCode.h"
#include "device/generic_sensor/public/interfaces/sensor.mojom-blink.h"
#include "device/generic_sensor/public/interfaces/sensor_provider.mojom-blink.h"
#include "mojo/public/cpp/bindings/binding.h"
@@ -31,7 +32,9 @@ class SensorProxy final : public GarbageCollectedFinalized<SensorProxy>,
// Platfrom sensort reading has changed (for 'ONCHANGE' reporting mode).
virtual void onSensorReadingChanged() {}
// An error has occurred.
- virtual void onSensorError() {}
+ virtual void onSensorError(ExceptionCode,
+ const String& sanitizedMessage,
+ const String& unsanitizedMessage) {}
};
~SensorProxy();
@@ -83,7 +86,9 @@ class SensorProxy final : public GarbageCollectedFinalized<SensorProxy>,
void SensorReadingChanged() override;
// Generic handler for a fatal error.
- void handleSensorError();
+ void handleSensorError(ExceptionCode = UnknownError,
+ const String& sanitizedMessage = String(),
+ const String& unsanitizedMessage = String());
void onSensorCreated(device::mojom::blink::SensorInitParamsPtr,
device::mojom::blink::SensorClientRequest);

Powered by Google App Engine
This is Rietveld 408576698