third_party/WebKit/Source/core/animation/AnimationEffectReadOnly.cpp - Issue 2384263003: Reflow comments in core/animation and subdirs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/AnimationEffectReadOnly.cpp

Issue 2384263003: Reflow comments in core/animation and subdirs (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/AnimationEffectReadOnly.h ('k') | third_party/WebKit/Source/core/animation/AnimationStack.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/AnimationEffectReadOnly.cpp

diff --git a/third_party/WebKit/Source/core/animation/AnimationEffectReadOnly.cpp b/third_party/WebKit/Source/core/animation/AnimationEffectReadOnly.cpp

index 3230438cead5843c7ccddf1d0d715581efbad658..16aa53b30e0c64b2149ddc10562620bdad505819 100644

--- a/third_party/WebKit/Source/core/animation/AnimationEffectReadOnly.cpp

+++ b/third_party/WebKit/Source/core/animation/AnimationEffectReadOnly.cpp

@@ -233,8 +233,10 @@ void AnimationEffectReadOnly::updateInheritedTime(

m_calculated.localTime = m_lastUpdateTime;

}

- // Test for events even if timing didn't need an update as the animation may have gained a start time.

- // FIXME: Refactor so that we can DCHECK(m_animation) here, this is currently required to be nullable for testing.

+ // Test for events even if timing didn't need an update as the animation may

+ // have gained a start time.

+ // FIXME: Refactor so that we can DCHECK(m_animation) here, this is currently

+ // required to be nullable for testing.

if (reason == TimingUpdateForAnimationFrame &&

(!m_animation || m_animation->hasStartTime() || m_animation->paused())) {

if (m_eventDelegate)