Don't record re-auths, unlocks, or secondary account additions in Signin.SigninStartedAccessPoint

chrome/browser/ui/webui/signin/inline_login_handler.cc

Index: chrome/browser/ui/webui/signin/inline_login_handler.cc
diff --git a/chrome/browser/ui/webui/signin/inline_login_handler.cc b/chrome/browser/ui/webui/signin/inline_login_handler.cc
index e13188bb5b8b210aba12d7c4d4384db8842c2c17..3f7b633eb371c34f8258d3edc9c1ee0058706b3a 100644
--- a/chrome/browser/ui/webui/signin/inline_login_handler.cc
+++ b/chrome/browser/ui/webui/signin/inline_login_handler.cc
@@ -195,15 +195,20 @@ void InlineLoginHandler::ContinueHandleInitializeMessage() {
   const GURL& current_url = web_ui()->GetWebContents()->GetURL();
   signin_metrics::AccessPoint access_point =
       signin::GetAccessPointForPromoURL(current_url);
-  signin_metrics::LogSigninAccessPointStarted(access_point);
+  signin_metrics::Reason reason =
+      signin::GetSigninReasonForPromoURL(current_url);
+
+  if (reason != signin_metrics::Reason::REASON_REAUTHENTICATION ||
+      reason != signin_metrics::Reason::REASON_UNLOCK ||
+      reason != signin_metrics::Reason::REASON_ADD_SECONDARY_ACCOUNT) {

[brucedawson, 2016/10/11 20:22:01]

Tautology error detected. |reason| will always be not equal to *one* of those
values. I assume you meant "==" instead of "!=" or "&&" instead of "||".

This was discovered by the experimental VC++ /analyze static analyze bot.
Warning was:

src\chrome\browser\ui\webui\signin\inline_login_handler.cc(201) : warning C6289:
Incorrect operator:  mutual exclusion over || is always a non-zero constant. 
Did you intend to use && instead?

Does this also point out a gap in test coverage?

Tracking bug for /analyze found errors is 427616.

+    signin_metrics::LogSigninAccessPointStarted(access_point);
+  }
   RecordSigninUserActionForAccessPoint(access_point);
   content::RecordAction(base::UserMetricsAction("Signin_SigninPage_Loading"));
 
   params.SetString("continueUrl", signin::GetLandingURL(access_point).spec());
 
   Profile* profile = Profile::FromWebUI(web_ui());
-  signin_metrics::Reason reason =
-      signin::GetSigninReasonForPromoURL(current_url);
   std::string default_email;
   if (reason == signin_metrics::Reason::REASON_SIGNIN_PRIMARY_ACCOUNT) {
     default_email =