Don't record re-auths, unlocks, or secondary account additions in Signin.SigninStartedAccessPoint

chrome/browser/ui/webui/signin/inline_login_handler.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/signin/inline_login_handler.h"
 
 #include <limits.h>
 
 #include "base/bind.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 177 matching lines @@
 
   const std::string& app_locale = g_browser_process->GetApplicationLocale();
   params.SetString("hl", app_locale);
   GaiaUrls* gaiaUrls = GaiaUrls::GetInstance();
   params.SetString("gaiaUrl", gaiaUrls->gaia_url().spec());
   params.SetInteger("authMode", InlineLoginHandler::kDesktopAuthMode);
 
   const GURL& current_url = web_ui()->GetWebContents()->GetURL();
   signin_metrics::AccessPoint access_point =
       signin::GetAccessPointForPromoURL(current_url);
-  signin_metrics::LogSigninAccessPointStarted(access_point);
+  signin_metrics::Reason reason =
+      signin::GetSigninReasonForPromoURL(current_url);
+
+  if (reason != signin_metrics::Reason::REASON_REAUTHENTICATION ||
+      reason != signin_metrics::Reason::REASON_UNLOCK ||
+      reason != signin_metrics::Reason::REASON_ADD_SECONDARY_ACCOUNT) {

[brucedawson, 2016/10/11 20:22:01]

Tautology error detected. |reason| will always be not equal to *one* of those
values. I assume you meant "==" instead of "!=" or "&&" instead of "||".

This was discovered by the experimental VC++ /analyze static analyze bot.
Warning was:

src\chrome\browser\ui\webui\signin\inline_login_handler.cc(201) : warning C6289:
Incorrect operator:  mutual exclusion over || is always a non-zero constant. 
Did you intend to use && instead?

Does this also point out a gap in test coverage?

Tracking bug for /analyze found errors is 427616.

+    signin_metrics::LogSigninAccessPointStarted(access_point);
+  }
   RecordSigninUserActionForAccessPoint(access_point);
   content::RecordAction(base::UserMetricsAction("Signin_SigninPage_Loading"));
 
   params.SetString("continueUrl", signin::GetLandingURL(access_point).spec());
 
   Profile* profile = Profile::FromWebUI(web_ui());
-  signin_metrics::Reason reason =
-      signin::GetSigninReasonForPromoURL(current_url);
   std::string default_email;
   if (reason == signin_metrics::Reason::REASON_SIGNIN_PRIMARY_ACCOUNT) {
     default_email =
         profile->GetPrefs()->GetString(prefs::kGoogleServicesLastUsername);
   } else {
     if (!net::GetValueForKeyInQuery(current_url, "email", &default_email))
       default_email.clear();
   }
   if (!default_email.empty())
     params.SetString("email", default_email);
@@ skipping 57 matching lines @@
 
 void InlineLoginHandler::HandleDialogClose(const base::ListValue* args) {
   Browser* browser = signin::GetDesktopBrowser(web_ui());
   // If the dialog was opened in the User Manager browser will be null here.
   if (browser)
     browser->CloseModalSigninWindow();
 
   // Does nothing if user manager is not showing.
   UserManager::HideReauthDialog();
 }