chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.h - Issue 2384213002: Send a TrackedPreference incident when registry pref validation fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.h

Issue 2384213002: Send a TrackedPreference incident when registry pref validation fails. (Closed)

Patch Set: Improve split preference handling and address comments on #3 Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.cc » ('j') | chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.h

diff --git a/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.h b/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.h

index 96bdeacdddd314c3e056e7cfaf87ff9d24bc8375..55d29f5d2607f957fbc5e139768763c4fe8c5508 100644

--- a/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.h

+++ b/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.h

@@ -34,12 +34,15 @@ class PreferenceValidationDelegate

const std::string& pref_path,

const base::Value* value,

PrefHashStoreTransaction::ValueState value_state,

+ PrefHashStoreTransaction::ValueState external_validation_value_state,

bool is_personal) override;

void OnSplitPreferenceValidation(

const std::string& pref_path,

const base::DictionaryValue* dict_value,

const std::vector<std::string>& invalid_keys,

+ const std::vector<std::string>& external_validation_invalid_keys,

PrefHashStoreTransaction::ValueState value_state,

+ PrefHashStoreTransaction::ValueState external_validation_value_state,

bool is_personal) override;

Profile* profile_;