Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(918)

Side by Side Diff: chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.h

Issue 2384213002: Send a TrackedPreference incident when registry pref validation fails. (Closed)
Patch Set: Improve split preference handling and address comments on #3 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SAFE_BROWSING_INCIDENT_REPORTING_PREFERENCE_VALIDATION_DE LEGATE_H_ 5 #ifndef CHROME_BROWSER_SAFE_BROWSING_INCIDENT_REPORTING_PREFERENCE_VALIDATION_DE LEGATE_H_
6 #define CHROME_BROWSER_SAFE_BROWSING_INCIDENT_REPORTING_PREFERENCE_VALIDATION_DE LEGATE_H_ 6 #define CHROME_BROWSER_SAFE_BROWSING_INCIDENT_REPORTING_PREFERENCE_VALIDATION_DE LEGATE_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 16 matching lines...) Expand all
27 Profile* profile, 27 Profile* profile,
28 std::unique_ptr<IncidentReceiver> incident_receiver); 28 std::unique_ptr<IncidentReceiver> incident_receiver);
29 ~PreferenceValidationDelegate() override; 29 ~PreferenceValidationDelegate() override;
30 30
31 private: 31 private:
32 // TrackedPreferenceValidationDelegate methods. 32 // TrackedPreferenceValidationDelegate methods.
33 void OnAtomicPreferenceValidation( 33 void OnAtomicPreferenceValidation(
34 const std::string& pref_path, 34 const std::string& pref_path,
35 const base::Value* value, 35 const base::Value* value,
36 PrefHashStoreTransaction::ValueState value_state, 36 PrefHashStoreTransaction::ValueState value_state,
37 PrefHashStoreTransaction::ValueState external_validation_value_state,
37 bool is_personal) override; 38 bool is_personal) override;
38 void OnSplitPreferenceValidation( 39 void OnSplitPreferenceValidation(
39 const std::string& pref_path, 40 const std::string& pref_path,
40 const base::DictionaryValue* dict_value, 41 const base::DictionaryValue* dict_value,
41 const std::vector<std::string>& invalid_keys, 42 const std::vector<std::string>& invalid_keys,
43 const std::vector<std::string>& external_validation_invalid_keys,
42 PrefHashStoreTransaction::ValueState value_state, 44 PrefHashStoreTransaction::ValueState value_state,
45 PrefHashStoreTransaction::ValueState external_validation_value_state,
43 bool is_personal) override; 46 bool is_personal) override;
44 47
45 Profile* profile_; 48 Profile* profile_;
46 std::unique_ptr<IncidentReceiver> incident_receiver_; 49 std::unique_ptr<IncidentReceiver> incident_receiver_;
47 50
48 DISALLOW_COPY_AND_ASSIGN(PreferenceValidationDelegate); 51 DISALLOW_COPY_AND_ASSIGN(PreferenceValidationDelegate);
49 }; 52 };
50 53
51 } // namespace safe_browsing 54 } // namespace safe_browsing
52 55
53 #endif // CHROME_BROWSER_SAFE_BROWSING_INCIDENT_REPORTING_PREFERENCE_VALIDATION _DELEGATE_H_ 56 #endif // CHROME_BROWSER_SAFE_BROWSING_INCIDENT_REPORTING_PREFERENCE_VALIDATION _DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698