Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2384123002: [Interpreter] Use RegisterList for kRegTriple and kRegPair operands. (Closed)

Created:
4 years, 2 months ago by rmcilroy
Modified:
4 years, 2 months ago
Reviewers:
mythria, Leszek Swirski
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Use RegisterList for kRegTriple and kRegPair operands. BUG=v8:4280 Committed: https://crrev.com/7e237ad3c8ecceed72507bc69adb257bc255fafa Cr-Commit-Position: refs/heads/master@{#40002}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -26 lines) Patch
M src/interpreter/bytecode-array-builder.h View 1 2 chunks +9 lines, -6 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 3 chunks +14 lines, -8 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 3 chunks +5 lines, -3 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-iterator-unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 17 (12 generated)
rmcilroy
PTAL, thanks.
4 years, 2 months ago (2016-10-03 10:23:03 UTC) #4
mythria
lgtm.
4 years, 2 months ago (2016-10-03 10:33:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384123002/20001
4 years, 2 months ago (2016-10-05 16:42:43 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-05 16:44:44 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 16:45:02 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7e237ad3c8ecceed72507bc69adb257bc255fafa
Cr-Commit-Position: refs/heads/master@{#40002}

Powered by Google App Engine
This is Rietveld 408576698