Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2382273002: [Interpreter]: Add kRegList operand type for register list operands. (Closed)

Created:
4 years, 2 months ago by rmcilroy
Modified:
4 years, 2 months ago
Reviewers:
mythria, Leszek Swirski
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter]: Add kRegList operand type for register list operands. Also get rid of useless kMaybeReg type. BUG=v8:4280 Committed: https://crrev.com/479e8f2346f6fd936a4b0f22319676f3ea424fd6 Cr-Commit-Position: refs/heads/master@{#40001}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Patch Set 3 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -86 lines) Patch
M src/interpreter/bytecode-array-builder.cc View 1 3 chunks +17 lines, -17 lines 0 comments Download
M src/interpreter/bytecode-array-iterator.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/interpreter/bytecode-decoder.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-decoder.cc View 5 chunks +38 lines, -14 lines 0 comments Download
M src/interpreter/bytecode-operands.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/interpreter/bytecode-register.h View 2 chunks +35 lines, -1 line 0 comments Download
M src/interpreter/bytecode-register.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/interpreter/bytecode-register-allocator.h View 1 chunk +0 lines, -30 lines 0 comments Download
M src/interpreter/bytecode-register-optimizer.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/interpreter/bytecodes.h View 3 chunks +15 lines, -11 lines 0 comments Download
M test/unittests/interpreter/bytecode-decoder-unittest.cc View 1 2 1 chunk +10 lines, -2 lines 0 comments Download
M test/unittests/interpreter/interpreter-assembler-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Issue 2384123002 Patch 20001

Messages

Total messages: 15 (9 generated)
rmcilroy
PTAL, thanks.
4 years, 2 months ago (2016-09-30 16:11:20 UTC) #5
mythria
Nice, lgtm. https://codereview.chromium.org/2382273002/diff/20001/test/unittests/interpreter/bytecode-decoder-unittest.cc File test/unittests/interpreter/bytecode-decoder-unittest.cc (right): https://codereview.chromium.org/2382273002/diff/20001/test/unittests/interpreter/bytecode-decoder-unittest.cc#newcode47 test/unittests/interpreter/bytecode-decoder-unittest.cc:47: " ForInPrepare r10, r11-r13"}, May be one ...
4 years, 2 months ago (2016-10-03 10:29:34 UTC) #8
rmcilroy
https://codereview.chromium.org/2382273002/diff/20001/test/unittests/interpreter/bytecode-decoder-unittest.cc File test/unittests/interpreter/bytecode-decoder-unittest.cc (right): https://codereview.chromium.org/2382273002/diff/20001/test/unittests/interpreter/bytecode-decoder-unittest.cc#newcode47 test/unittests/interpreter/bytecode-decoder-unittest.cc:47: " ForInPrepare r10, r11-r13"}, On 2016/10/03 10:29:34, mythria wrote: ...
4 years, 2 months ago (2016-10-05 15:48:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2382273002/60001
4 years, 2 months ago (2016-10-05 15:49:02 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 2 months ago (2016-10-05 16:14:19 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 16:14:43 UTC) #15
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/479e8f2346f6fd936a4b0f22319676f3ea424fd6
Cr-Commit-Position: refs/heads/master@{#40001}

Powered by Google App Engine
This is Rietveld 408576698