Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2384063009: Re-land "Refactor ScrollableArea::setScrollPosition." (Closed)

Created:
4 years, 2 months ago by szager1
Modified:
4 years, 2 months ago
Reviewers:
imcheng, eae
CC:
chromium-reviews, blink-reviews-html_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, eae+blinkwatch, shans, rwlbuis, krit, drott+blinkwatch_chromium.org, szager+layoutwatch_chromium.org, Justin Novosad, dglazkov+blink, Rik, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews, ajuma+watch_chromium.org, Eric Willigers, rjwright, zoltan1, blink-reviews-layout_chromium.org, jbroman, pdr+graphicswatchlist_chromium.org, darktears, Stephen Chennney, blink-reviews-animation_chromium.org, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, blink-layers+watch_chromium.org, f(malita), danakj+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-land "Refactor ScrollableArea::setScrollPosition." Re-landing this change: https://codereview.chromium.org/2383113003/ ... which was reverted because it caused conflicts when trying to revert a preceding commit which broke tests. The bad commit was: https://codereview.chromium.org/2391893004/ BUG=417782 TBR=eae@chromium.org,imcheng@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/eaebaf1b82c347c29595c1c6f85f87b59ec9523d Cr-Commit-Position: refs/heads/master@{#423079}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -141 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.cpp View 2 chunks +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp View 1 chunk +3 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 6 chunks +35 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObjectTest.cpp View 5 chunks +25 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ScrollEnums.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/SpatialNavigation.cpp View 1 chunk +4 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h View 2 chunks +9 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 6 chunks +20 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp View 1 chunk +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollableArea.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp View 1 chunk +10 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
szager1
4 years, 2 months ago (2016-10-05 01:43:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384063009/1
4 years, 2 months ago (2016-10-05 01:43:58 UTC) #4
imcheng
lgtm
4 years, 2 months ago (2016-10-05 01:47:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 05:12:30 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 05:15:27 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/eaebaf1b82c347c29595c1c6f85f87b59ec9523d
Cr-Commit-Position: refs/heads/master@{#423079}

Powered by Google App Engine
This is Rietveld 408576698