Propagate common resources to WebView child process

Propagate common resources to WebView child process

WebView uses the same resources file scheme as Chrome
since https://codereview.chromium.org/2248743002.
In case of multiprocess WebView we need to pass the common
resources pak (chrome_100_percent.pak) to the renderer process.

BUG=634358, 638344
Committed: https://crrev.com/a0a347d16cb6ad810e1b2e488a3f58923769565e
Cr-Commit-Position: refs/heads/master@{#422822}

[Tima Vaisburd, 2016-10-04 00:48:54]

The CQ bit was checked by timav@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 00:49:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tima Vaisburd, 2016-10-04 00:50:35]

timav@chromium.org changed reviewers:
+ aberent@chromium.org, michaelbai@chromium.org

[Tima Vaisburd, 2016-10-04 00:50:36]

PTAL.

[michaelbai, 2016-10-04 01:09:14]

LGTM, I were thinking this part of code is shared with chrome, it is actually
very similar now, see chrome part.

https://cs.chromium.org/chromium/src/chrome/browser/chrome_content_browser_cl...

Would you like to create a bug to track this issue?

[Tima Vaisburd, 2016-10-04 01:12:41]

Description was changed from

==========
Propagate common resources to WebView child process

WebView uses the same resources file scheme as Chrome
since https://codereview.chromium.org/2248743002.
In case of multiprocess WebView we need to pass the common
resources pak (chrome_100_percent.pak) to the renderer process.

BUG=638344
==========

to

==========
Propagate common resources to WebView child process

WebView uses the same resources file scheme as Chrome
since https://codereview.chromium.org/2248743002.
In case of multiprocess WebView we need to pass the common
resources pak (chrome_100_percent.pak) to the renderer process.

BUG=634358, 638344
==========

[Tima Vaisburd, 2016-10-04 01:16:12]

On 2016/10/04 01:09:14, michaelbai wrote:
> LGTM, I were thinking this part of code is shared with chrome, it is actually
> very similar now, see chrome part.
> 
>
https://cs.chromium.org/chromium/src/chrome/browser/chrome_content_browser_cl...

Yes, I was looking there trying to understand how it works and how I should fix
it.
 
> Would you like to create a bug to track this issue?

In my mind this fix should be part of
https://codereview.chromium.org/2248743002,
I added the bug of that CL to BUG=...

Or is it that now we have code duplication between Chrome and AW and this is the
issue?

[michaelbai, 2016-10-04 01:23:50]

On 2016/10/04 01:16:12, Tima Vaisburd wrote:
> On 2016/10/04 01:09:14, michaelbai wrote:
> > LGTM, I were thinking this part of code is shared with chrome, it is
actually
> > very similar now, see chrome part.
> > 
> >
>
https://cs.chromium.org/chromium/src/chrome/browser/chrome_content_browser_cl...
> 
> Yes, I was looking there trying to understand how it works and how I should
fix
> it.
>  
> > Would you like to create a bug to track this issue?
> 
> In my mind this fix should be part of
> https://codereview.chromium.org/2248743002,
> I added the bug of that CL to BUG=...
> 
> Or is it that now we have code duplication between Chrome and AW and this is
the
> issue?


The duplicate code is the issue, since WebView and Chrome already have same pak
file name, the code shall also be shared

[commit-bot: I haz the power, 2016-10-04 01:54:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 01:54:07]

Dry run: This issue passed the CQ dry run.

[aberent, 2016-10-04 08:09:58]

LGTM.

[Tima Vaisburd, 2016-10-04 16:09:13]

The CQ bit was checked by timav@chromium.org

[commit-bot: I haz the power, 2016-10-04 16:09:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 16:14:41]

Description was changed from

==========
Propagate common resources to WebView child process

WebView uses the same resources file scheme as Chrome
since https://codereview.chromium.org/2248743002.
In case of multiprocess WebView we need to pass the common
resources pak (chrome_100_percent.pak) to the renderer process.

BUG=634358, 638344
==========

to

==========
Propagate common resources to WebView child process

WebView uses the same resources file scheme as Chrome
since https://codereview.chromium.org/2248743002.
In case of multiprocess WebView we need to pass the common
resources pak (chrome_100_percent.pak) to the renderer process.

BUG=634358, 638344
==========

[commit-bot: I haz the power, 2016-10-04 16:14:42]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-04 16:15:53]

Description was changed from

==========
Propagate common resources to WebView child process

WebView uses the same resources file scheme as Chrome
since https://codereview.chromium.org/2248743002.
In case of multiprocess WebView we need to pass the common
resources pak (chrome_100_percent.pak) to the renderer process.

BUG=634358, 638344
==========

to

==========
Propagate common resources to WebView child process

WebView uses the same resources file scheme as Chrome
since https://codereview.chromium.org/2248743002.
In case of multiprocess WebView we need to pass the common
resources pak (chrome_100_percent.pak) to the renderer process.

BUG=634358, 638344

Committed: https://crrev.com/a0a347d16cb6ad810e1b2e488a3f58923769565e
Cr-Commit-Position: refs/heads/master@{#422822}
==========

[commit-bot: I haz the power, 2016-10-04 16:15:54]

Patchset 1 (id:??) landed as
https://crrev.com/a0a347d16cb6ad810e1b2e488a3f58923769565e
Cr-Commit-Position: refs/heads/master@{#422822}