Fix missing monochrome resources.

Fix missing monochrome resources.

As a result of https://codereview.chromium.org/2235753002
monochrome was failing to find some resources. Instead of
looking in two places for the PAK files this CL changes
the organization of the webview PAK files to match those
of Chrome, hence allowing identical behaviour for
Monochrome and isolated Webview.

In doing so it reverts the changes to resource_bundle_android.*
that were made in the previous CL.

BUG=634358
Committed: https://crrev.com/3bcea370cbe5f65605d2211f1145280e455af1eb
Cr-Commit-Position: refs/heads/master@{#412218}

[aberent, 2016-08-15 15:46:18]

aberent@chromium.org changed reviewers:
+ dtrainor@chromium.org, sky@chromium.org, torne@chromium.org

[aberent, 2016-08-15 15:46:19]

torne@chromium.org: Complete review please, including OWNER review of
//android_webview/...

dtrainor@chromium.org: OWNER review please of monochrome_entry_point.cc 

sky@chromium.org: OWNER review please of resource_bundle_android.*. Note that
this precisely reverses the changes made to these files in the previous CL.

[aberent, 2016-08-15 15:48:17]

The CQ bit was checked by aberent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 15:48:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2016-08-15 16:20:49]

LGTM

[commit-bot: I haz the power, 2016-08-15 16:58:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 16:58:27]

Dry run: This issue passed the CQ dry run.

[aberent, 2016-08-15 19:02:31]

torne@ pointed out that Patch set 2 won't work with 64 bit Monochrome, since
there the binary stated as Webview since Chrome is 32 bit. This takes us back to
what we should have done in the first place, which is to change the Webview
resource file names and organization to match those of Chrome.

[aberent, 2016-08-15 19:06:00]

Description was changed from

==========
Fix missing monochrome resources.

As a result of https://codereview.chromium.org/2235753002
monochrome was failing to find some resources. This rethinks
some parts of that CL, and fixes this, by adding an
explicit flag that says whether the running Webview is
stand alone Webview or Monochrome.

In doing so it reverts the changes to resource_bundle_android.*
that were made in the previous CL.

BUG=634358
==========

to

==========
Fix missing monochrome resources.

As a result of https://codereview.chromium.org/2235753002
monochrome was failing to find some resources. Instead of
looking in two places for the PAK files this CL changes
the organization of the webview PAK files to match those
of Chrome, hence allowing identical behaviour for
Monochrome and isolated Webview.

In doing so it reverts the changes to resource_bundle_android.*
that were made in the previous CL.

BUG=634358
==========

[aberent, 2016-08-15 19:08:22]

aberent@chromium.org changed reviewers:
- dtrainor@chromium.org

[aberent, 2016-08-15 19:08:22]

dtrainor@ - This no longer changes anything in //chrome, so I have removed you
from the reviewer list.

[aberent, 2016-08-15 19:14:01]

The CQ bit was checked by aberent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 19:14:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 20:13:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 20:13:05]

Dry run: This issue passed the CQ dry run.

[Torne, 2016-08-16 11:32:27]

Aha, I like this a lot :)

How much have you been able to test this? It's not obvious to figure out which
things in webview load chromium native resources. Is there a simple way to
verify that the two .pak files combined definitely contain the same resources as
the old .pak file?

[Torne, 2016-08-16 11:33:11]

Oh, I did also mean to say LGTM.

[aberent, 2016-08-16 12:09:14]

On 2016/08/16 11:33:11, Torne wrote:
> Oh, I did also mean to say LGTM.

I checked that the sum of the sizes of the new PAK files was similar to the size
of the old PAK file, and I did some quite basic manual tests of both stand alone
Webview and of Monochrome. I know that it was successfully reading at least some
of the 100 percent resources, since it would have DCHECKed on startup (as I
previously discovered) if it hadn't found them.

One could, I suppose hack together a script to list the resource ids in the PAK
files, and compare the two lists, but my feeling is that, if this was broken, it
would break quite badly with DCHECKs quite early.

[aberent, 2016-08-16 12:09:28]

The CQ bit was checked by aberent@chromium.org

[aberent, 2016-08-16 12:09:28]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2248743002/#ps40001
(title: "Rethink: change webview resource files to match chrome")

[commit-bot: I haz the power, 2016-08-16 12:09:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 12:13:14]

Description was changed from

==========
Fix missing monochrome resources.

As a result of https://codereview.chromium.org/2235753002
monochrome was failing to find some resources. Instead of
looking in two places for the PAK files this CL changes
the organization of the webview PAK files to match those
of Chrome, hence allowing identical behaviour for
Monochrome and isolated Webview.

In doing so it reverts the changes to resource_bundle_android.*
that were made in the previous CL.

BUG=634358
==========

to

==========
Fix missing monochrome resources.

As a result of https://codereview.chromium.org/2235753002
monochrome was failing to find some resources. Instead of
looking in two places for the PAK files this CL changes
the organization of the webview PAK files to match those
of Chrome, hence allowing identical behaviour for
Monochrome and isolated Webview.

In doing so it reverts the changes to resource_bundle_android.*
that were made in the previous CL.

BUG=634358
==========

[commit-bot: I haz the power, 2016-08-16 12:13:15]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-16 12:14:46]

Description was changed from

==========
Fix missing monochrome resources.

As a result of https://codereview.chromium.org/2235753002
monochrome was failing to find some resources. Instead of
looking in two places for the PAK files this CL changes
the organization of the webview PAK files to match those
of Chrome, hence allowing identical behaviour for
Monochrome and isolated Webview.

In doing so it reverts the changes to resource_bundle_android.*
that were made in the previous CL.

BUG=634358
==========

to

==========
Fix missing monochrome resources.

As a result of https://codereview.chromium.org/2235753002
monochrome was failing to find some resources. Instead of
looking in two places for the PAK files this CL changes
the organization of the webview PAK files to match those
of Chrome, hence allowing identical behaviour for
Monochrome and isolated Webview.

In doing so it reverts the changes to resource_bundle_android.*
that were made in the previous CL.

BUG=634358

Committed: https://crrev.com/3bcea370cbe5f65605d2211f1145280e455af1eb
Cr-Commit-Position: refs/heads/master@{#412218}
==========

[commit-bot: I haz the power, 2016-08-16 12:14:47]

Patchset 3 (id:??) landed as
https://crrev.com/3bcea370cbe5f65605d2211f1145280e455af1eb
Cr-Commit-Position: refs/heads/master@{#412218}