Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2384053002: cancel overlay-scrollbar hover state when moving pointer out of window for ChromeOS (Closed)

Created:
4 years, 2 months ago by chaopeng
Modified:
4 years, 2 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, dtapuska+chromiumwatch_chromium.org, tdresser+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cancel overlay-scrollbar hover state when moving pointer out of window for ChromeOS For this bug convert ET_MOUSE_EXITED to MouseLeave in ChromeOS and make the scrollbar thin and light when we receive MouseLeave. For other platform, we will fix this bug after crbug.com/450631 BUG=332227 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/3ba6cb3d9518e9a54f006fd6288438c211ba8998 Committed: https://crrev.com/fff2d5ac5578916345697e5612fa33e2f75a4dec Cr-Original-Commit-Position: refs/heads/master@{#424531} Cr-Commit-Position: refs/heads/master@{#425045}

Patch Set 1 #

Patch Set 2 : remove a line #

Patch Set 3 : for chromeos #

Patch Set 4 : remove fix for not chromeos #

Total comments: 2

Patch Set 5 : fix a bug #

Total comments: 3

Patch Set 6 : style #

Patch Set 7 : fix for near scrollbar then out #

Patch Set 8 : fix for near scrollbar then out #

Total comments: 4

Patch Set 9 : add DCHECK #

Total comments: 1

Patch Set 10 : add DCHECK #

Total comments: 5

Patch Set 11 : move to DidMouseMoveOffScrollbar #

Patch Set 12 : reset scroll_layer_id_when_mouse_near_scrollbar_ and scroll_layer_id_when_mouse_over_scrollbar_ whe… #

Patch Set 13 : reset scroll_layer_id_when_mouse_near_scrollbar_ and scroll_layer_id_when_mouse_over_scrollbar_ whe… #

Patch Set 14 : reset scroll_layer_id_when_mouse_over_scrollbar_ when mouse out of windows #

Total comments: 2

Patch Set 15 : change to loop all animatior #

Total comments: 1

Patch Set 16 : quick return #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -1 line) Patch
M cc/input/input_handler.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
M cc/input/scrollbar_animation_controller_thinning.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +3 lines, -0 lines 0 comments Download
M cc/input/scrollbar_animation_controller_thinning_unittest.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +35 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +7 lines, -0 lines 0 comments Download
M ui/events/blink/input_handler_proxy.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +5 lines, -0 lines 0 comments Download
M ui/events/blink/input_handler_proxy_unittest.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/blink/web_input_event.cc View 1 2 7 12 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 56 (30 generated)
chaopeng
4 years, 2 months ago (2016-10-04 18:21:35 UTC) #10
chaopeng
4 years, 2 months ago (2016-10-04 19:09:44 UTC) #12
dtapuska
https://codereview.chromium.org/2384053002/diff/60001/cc/input/scrollbar_animation_controller_thinning.cc File cc/input/scrollbar_animation_controller_thinning.cc (right): https://codereview.chromium.org/2384053002/diff/60001/cc/input/scrollbar_animation_controller_thinning.cc#newcode143 cc/input/scrollbar_animation_controller_thinning.cc:143: opacity_change_ = DECREASE; Is it possible that the mouse_is_over_scrollbar_ ...
4 years, 2 months ago (2016-10-04 20:16:22 UTC) #13
chaopeng
Updated. PTAL. https://codereview.chromium.org/2384053002/diff/60001/cc/input/scrollbar_animation_controller_thinning.cc File cc/input/scrollbar_animation_controller_thinning.cc (right): https://codereview.chromium.org/2384053002/diff/60001/cc/input/scrollbar_animation_controller_thinning.cc#newcode143 cc/input/scrollbar_animation_controller_thinning.cc:143: opacity_change_ = DECREASE; On 2016/10/04 20:16:22, dtapuska ...
4 years, 2 months ago (2016-10-04 20:48:10 UTC) #15
dtapuska
On 2016/10/04 20:48:10, chaopeng wrote: > Updated. PTAL. > > https://codereview.chromium.org/2384053002/diff/60001/cc/input/scrollbar_animation_controller_thinning.cc > File cc/input/scrollbar_animation_controller_thinning.cc (right): ...
4 years, 2 months ago (2016-10-04 20:50:14 UTC) #16
dtapuska
https://codereview.chromium.org/2384053002/diff/80001/cc/trees/layer_tree_host_impl.cc File cc/trees/layer_tree_host_impl.cc (right): https://codereview.chromium.org/2384053002/diff/80001/cc/trees/layer_tree_host_impl.cc#newcode3274 cc/trees/layer_tree_host_impl.cc:3274: if (animation_controller) { don't think you need the scope ...
4 years, 2 months ago (2016-10-04 20:50:23 UTC) #17
bokan
https://codereview.chromium.org/2384053002/diff/80001/cc/trees/layer_tree_host_impl.cc File cc/trees/layer_tree_host_impl.cc (right): https://codereview.chromium.org/2384053002/diff/80001/cc/trees/layer_tree_host_impl.cc#newcode3270 cc/trees/layer_tree_host_impl.cc:3270: ScrollbarAnimationController* animation_controller = What if the mouse isn't over ...
4 years, 2 months ago (2016-10-04 20:57:41 UTC) #18
chaopeng
4 years, 2 months ago (2016-10-04 21:02:04 UTC) #21
chaopeng
https://codereview.chromium.org/2384053002/diff/80001/cc/trees/layer_tree_host_impl.cc File cc/trees/layer_tree_host_impl.cc (right): https://codereview.chromium.org/2384053002/diff/80001/cc/trees/layer_tree_host_impl.cc#newcode3270 cc/trees/layer_tree_host_impl.cc:3270: ScrollbarAnimationController* animation_controller = On 2016/10/04 20:57:41, bokan wrote: > ...
4 years, 2 months ago (2016-10-05 02:29:29 UTC) #22
bokan
https://codereview.chromium.org/2384053002/diff/140001/cc/trees/layer_tree_host_impl.cc File cc/trees/layer_tree_host_impl.cc (right): https://codereview.chromium.org/2384053002/diff/140001/cc/trees/layer_tree_host_impl.cc#newcode3236 cc/trees/layer_tree_host_impl.cc:3236: scroll_layer_id_when_mouse_near_scrollbar_ = Layer::INVALID_ID; lets clear scroll_layer_id_when_mouse_over_scrollbar_ here too. https://codereview.chromium.org/2384053002/diff/140001/cc/trees/layer_tree_host_impl.cc#newcode3276 ...
4 years, 2 months ago (2016-10-05 12:32:11 UTC) #30
chaopeng
Updated. PTAL. Thank you. https://codereview.chromium.org/2384053002/diff/140001/cc/trees/layer_tree_host_impl.cc File cc/trees/layer_tree_host_impl.cc (right): https://codereview.chromium.org/2384053002/diff/140001/cc/trees/layer_tree_host_impl.cc#newcode3236 cc/trees/layer_tree_host_impl.cc:3236: scroll_layer_id_when_mouse_near_scrollbar_ = Layer::INVALID_ID; On 2016/10/05 ...
4 years, 2 months ago (2016-10-05 13:55:32 UTC) #31
bokan
lgtm % nit https://codereview.chromium.org/2384053002/diff/140001/cc/trees/layer_tree_host_impl.cc File cc/trees/layer_tree_host_impl.cc (right): https://codereview.chromium.org/2384053002/diff/140001/cc/trees/layer_tree_host_impl.cc#newcode3236 cc/trees/layer_tree_host_impl.cc:3236: scroll_layer_id_when_mouse_near_scrollbar_ = Layer::INVALID_ID; On 2016/10/05 13:55:32, ...
4 years, 2 months ago (2016-10-05 14:00:09 UTC) #32
aelias_OOO_until_Jul13
https://codereview.chromium.org/2384053002/diff/180001/cc/input/scrollbar_animation_controller_thinning.cc File cc/input/scrollbar_animation_controller_thinning.cc (right): https://codereview.chromium.org/2384053002/diff/180001/cc/input/scrollbar_animation_controller_thinning.cc#newcode137 cc/input/scrollbar_animation_controller_thinning.cc:137: void ScrollbarAnimationControllerThinning::DidMouseLeave() { This seems very similar to DidMouseMoveOffScrollbar, ...
4 years, 2 months ago (2016-10-07 02:09:52 UTC) #33
dtapuska
https://codereview.chromium.org/2384053002/diff/180001/ui/events/blink/web_input_event.cc File ui/events/blink/web_input_event.cc (right): https://codereview.chromium.org/2384053002/diff/180001/ui/events/blink/web_input_event.cc#newcode405 ui/events/blink/web_input_event.cc:405: #if defined(OS_CHROMEOS) On 2016/10/07 02:09:51, aelias wrote: > Platform ...
4 years, 2 months ago (2016-10-07 14:30:39 UTC) #34
chaopeng
CL updated. I also add reset scroll_layer_id_when_mouse_over_scrollbar_ when mouse move out of window. PTAL. Thank ...
4 years, 2 months ago (2016-10-07 15:56:04 UTC) #35
aelias_OOO_until_Jul13
https://codereview.chromium.org/2384053002/diff/180001/ui/events/blink/web_input_event.cc File ui/events/blink/web_input_event.cc (right): https://codereview.chromium.org/2384053002/diff/180001/ui/events/blink/web_input_event.cc#newcode405 ui/events/blink/web_input_event.cc:405: #if defined(OS_CHROMEOS) On 2016/10/07 at 14:30:39, dtapuska wrote: > ...
4 years, 2 months ago (2016-10-07 16:26:19 UTC) #37
chaopeng
https://codereview.chromium.org/2384053002/diff/260001/cc/trees/layer_tree_host_impl.h File cc/trees/layer_tree_host_impl.h (right): https://codereview.chromium.org/2384053002/diff/260001/cc/trees/layer_tree_host_impl.h#newcode750 cc/trees/layer_tree_host_impl.h:750: int scroll_layer_id_when_mouse_near_scrollbar_; On 2016/10/07 16:26:19, aelias wrote: > Why's ...
4 years, 2 months ago (2016-10-07 18:06:16 UTC) #38
aelias_OOO_until_Jul13
lgtm https://codereview.chromium.org/2384053002/diff/280001/cc/input/scrollbar_animation_controller_thinning.cc File cc/input/scrollbar_animation_controller_thinning.cc (right): https://codereview.chromium.org/2384053002/diff/280001/cc/input/scrollbar_animation_controller_thinning.cc#newcode85 cc/input/scrollbar_animation_controller_thinning.cc:85: if (mouse_is_over_scrollbar_ || mouse_is_near_scrollbar_) { Nit: preferred pattern ...
4 years, 2 months ago (2016-10-11 19:00:32 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384053002/300001
4 years, 2 months ago (2016-10-11 19:08:34 UTC) #42
commit-bot: I haz the power
Patchset 16 (id:??) landed as https://crrev.com/351b1d8638edcf2ce37f6d89b0908313780e7dd6 Cr-Commit-Position: refs/heads/master@{#424530}
4 years, 2 months ago (2016-10-11 20:33:33 UTC) #44
commit-bot: I haz the power
Committed patchset #16 (id:300001)
4 years, 2 months ago (2016-10-11 20:33:37 UTC) #46
commit-bot: I haz the power
Patchset 16 (id:??) landed as https://crrev.com/3ba6cb3d9518e9a54f006fd6288438c211ba8998 Cr-Commit-Position: refs/heads/master@{#424531}
4 years, 2 months ago (2016-10-11 20:36:04 UTC) #48
alph
A revert of this CL (patchset #16 id:300001) has been created in https://codereview.chromium.org/2406233004/ by alph@chromium.org. ...
4 years, 2 months ago (2016-10-11 21:00:00 UTC) #49
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384053002/300001
4 years, 2 months ago (2016-10-13 14:54:11 UTC) #52
commit-bot: I haz the power
Committed patchset #16 (id:300001)
4 years, 2 months ago (2016-10-13 15:42:27 UTC) #54
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 15:44:21 UTC) #56
Message was sent while issue was closed.
Patchset 16 (id:??) landed as
https://crrev.com/fff2d5ac5578916345697e5612fa33e2f75a4dec
Cr-Commit-Position: refs/heads/master@{#425045}

Powered by Google App Engine
This is Rietveld 408576698