|
|
Descriptioncancel overlay-scrollbar hover state when moving pointer out of window for ChromeOS
For this bug convert ET_MOUSE_EXITED to MouseLeave in ChromeOS and make the
scrollbar thin and light when we receive MouseLeave.
For other platform, we will fix this bug after crbug.com/450631
BUG=332227
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
Committed: https://crrev.com/3ba6cb3d9518e9a54f006fd6288438c211ba8998
Committed: https://crrev.com/fff2d5ac5578916345697e5612fa33e2f75a4dec
Cr-Original-Commit-Position: refs/heads/master@{#424531}
Cr-Commit-Position: refs/heads/master@{#425045}
Patch Set 1 #Patch Set 2 : remove a line #Patch Set 3 : for chromeos #Patch Set 4 : remove fix for not chromeos #
Total comments: 2
Patch Set 5 : fix a bug #
Total comments: 3
Patch Set 6 : style #Patch Set 7 : fix for near scrollbar then out #Patch Set 8 : fix for near scrollbar then out #
Total comments: 4
Patch Set 9 : add DCHECK #
Total comments: 1
Patch Set 10 : add DCHECK #
Total comments: 5
Patch Set 11 : move to DidMouseMoveOffScrollbar #Patch Set 12 : reset scroll_layer_id_when_mouse_near_scrollbar_ and scroll_layer_id_when_mouse_over_scrollbar_ whe… #Patch Set 13 : reset scroll_layer_id_when_mouse_near_scrollbar_ and scroll_layer_id_when_mouse_over_scrollbar_ whe… #Patch Set 14 : reset scroll_layer_id_when_mouse_over_scrollbar_ when mouse out of windows #
Total comments: 2
Patch Set 15 : change to loop all animatior #
Total comments: 1
Patch Set 16 : quick return #Messages
Total messages: 56 (30 generated)
Description was changed from ========== cancel scrollbar hover state when moving pointer outside of window For this bug we do hittest to RootScrollLayer when mouse move. We cancel hover state if mouse leave windows. BUG=332227 ========== to ========== cancel scrollbar hover state when moving pointer outside of window For this bug we do hittest to RootScrollLayer when mouse move. We cancel hover state if mouse leave windows. BUG=332227 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ==========
Description was changed from ========== cancel scrollbar hover state when moving pointer outside of window For this bug we do hittest to RootScrollLayer when mouse move. We cancel hover state if mouse leave windows. BUG=332227 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ========== to ========== cancel scrollbar hover state when moving pointer outside of window For this bug we do hittest to RootScrollLayer when mouse move. We cancel hover state if mouse leave windows. BUG=332227 ==========
The CQ bit was checked by chaopeng@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== cancel scrollbar hover state when moving pointer outside of window For this bug we do hittest to RootScrollLayer when mouse move. We cancel hover state if mouse leave windows. BUG=332227 ========== to ========== cancel scrollbar hover state when moving pointer outside of window For this bug we do hittest to RootScrollLayer when mouse move. We cancel hover state if mouse leave windows. BUG=332227 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ==========
Description was changed from ========== cancel scrollbar hover state when moving pointer outside of window For this bug we do hittest to RootScrollLayer when mouse move. We cancel hover state if mouse leave windows. BUG=332227 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ========== to ========== cancel overlay-scrollbar hover state when moving pointer out of window for ChromeOS For this bug convert ET_MOUSE_EXITED to MouseLeave in ChromeOS and make the scrollbar thin and light when we receive MouseLeave. For other platform, we will fix this bug after crbug.com/450631 BUG=332227 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ==========
Description was changed from ========== cancel overlay-scrollbar hover state when moving pointer out of window for ChromeOS For this bug convert ET_MOUSE_EXITED to MouseLeave in ChromeOS and make the scrollbar thin and light when we receive MouseLeave. For other platform, we will fix this bug after crbug.com/450631 BUG=332227 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ========== to ========== cancel overlay-scrollbar hover state when moving pointer out of window for ChromeOS For this bug convert ET_MOUSE_EXITED to MouseLeave in ChromeOS and make the scrollbar thin and light when we receive MouseLeave. For other platform, we will fix this bug after crbug.com/450631 ==========
chaopeng@chromium.org changed reviewers: + bokan@chromium.org, dtapuska@chromium.org
https://codereview.chromium.org/2384053002/diff/60001/cc/input/scrollbar_anim... File cc/input/scrollbar_animation_controller_thinning.cc (right): https://codereview.chromium.org/2384053002/diff/60001/cc/input/scrollbar_anim... cc/input/scrollbar_animation_controller_thinning.cc:143: opacity_change_ = DECREASE; Is it possible that the mouse_is_over_scrollbar_ and !mouse_is_near_scrollbar_ which then the animation to hide it never kicks off?
Description was changed from ========== cancel overlay-scrollbar hover state when moving pointer out of window for ChromeOS For this bug convert ET_MOUSE_EXITED to MouseLeave in ChromeOS and make the scrollbar thin and light when we receive MouseLeave. For other platform, we will fix this bug after crbug.com/450631 ========== to ========== cancel overlay-scrollbar hover state when moving pointer out of window for ChromeOS For this bug convert ET_MOUSE_EXITED to MouseLeave in ChromeOS and make the scrollbar thin and light when we receive MouseLeave. For other platform, we will fix this bug after crbug.com/450631 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ==========
Updated. PTAL. https://codereview.chromium.org/2384053002/diff/60001/cc/input/scrollbar_anim... File cc/input/scrollbar_animation_controller_thinning.cc (right): https://codereview.chromium.org/2384053002/diff/60001/cc/input/scrollbar_anim... cc/input/scrollbar_animation_controller_thinning.cc:143: opacity_change_ = DECREASE; On 2016/10/04 20:16:22, dtapuska wrote: > Is it possible that the mouse_is_over_scrollbar_ and !mouse_is_near_scrollbar_ > which then the animation to hide it never kicks off? I have a issue have, should move StartAnimation out.
On 2016/10/04 20:48:10, chaopeng wrote: > Updated. PTAL. > > https://codereview.chromium.org/2384053002/diff/60001/cc/input/scrollbar_anim... > File cc/input/scrollbar_animation_controller_thinning.cc (right): > > https://codereview.chromium.org/2384053002/diff/60001/cc/input/scrollbar_anim... > cc/input/scrollbar_animation_controller_thinning.cc:143: opacity_change_ = > DECREASE; > On 2016/10/04 20:16:22, dtapuska wrote: > > Is it possible that the mouse_is_over_scrollbar_ and !mouse_is_near_scrollbar_ > > > which then the animation to hide it never kicks off? > > I have a issue have, should move StartAnimation out. lgtm % nit and you'll need a cc owner.
https://codereview.chromium.org/2384053002/diff/80001/cc/trees/layer_tree_hos... File cc/trees/layer_tree_host_impl.cc (right): https://codereview.chromium.org/2384053002/diff/80001/cc/trees/layer_tree_hos... cc/trees/layer_tree_host_impl.cc:3274: if (animation_controller) { don't think you need the scope brackets :-)
https://codereview.chromium.org/2384053002/diff/80001/cc/trees/layer_tree_hos... File cc/trees/layer_tree_host_impl.cc (right): https://codereview.chromium.org/2384053002/diff/80001/cc/trees/layer_tree_hos... cc/trees/layer_tree_host_impl.cc:3270: ScrollbarAnimationController* animation_controller = What if the mouse isn't over the scrollbar though, rather near it when the mouse leaves the window. This can happen if the mouse moves really quickly or if there's a DIV whose scrollbars are showing. (DIVs do work, but only if they're composited. To test, try running with the --enable-prefer-compositing-to-lcd-text flag, that should enable animated scrollbars on most DIVs and IFrames.
Description was changed from ========== cancel overlay-scrollbar hover state when moving pointer out of window for ChromeOS For this bug convert ET_MOUSE_EXITED to MouseLeave in ChromeOS and make the scrollbar thin and light when we receive MouseLeave. For other platform, we will fix this bug after crbug.com/450631 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ========== to ========== cancel overlay-scrollbar hover state when moving pointer out of window for ChromeOS For this bug convert ET_MOUSE_EXITED to MouseLeave in ChromeOS and make the scrollbar thin and light when we receive MouseLeave. For other platform, we will fix this bug after crbug.com/450631 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ==========
chaopeng@chromium.org changed reviewers: + aelias@chromium.org
https://codereview.chromium.org/2384053002/diff/80001/cc/trees/layer_tree_hos... File cc/trees/layer_tree_host_impl.cc (right): https://codereview.chromium.org/2384053002/diff/80001/cc/trees/layer_tree_hos... cc/trees/layer_tree_host_impl.cc:3270: ScrollbarAnimationController* animation_controller = On 2016/10/04 20:57:41, bokan wrote: > What if the mouse isn't over the scrollbar though, rather near it when the mouse > leaves the window. This can happen if the mouse moves really quickly or if > there's a DIV whose scrollbars are showing. (DIVs do work, but only if they're > composited. To test, try running with the > --enable-prefer-compositing-to-lcd-text flag, that should enable animated > scrollbars on most DIVs and IFrames. Yes, It doesnot work for near-moveout. I add a new patch for this. PTAL. Thank you.
The CQ bit was checked by chaopeng@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by chaopeng@chromium.org
The CQ bit was checked by chaopeng@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2384053002/diff/140001/cc/trees/layer_tree_ho... File cc/trees/layer_tree_host_impl.cc (right): https://codereview.chromium.org/2384053002/diff/140001/cc/trees/layer_tree_ho... cc/trees/layer_tree_host_impl.cc:3236: scroll_layer_id_when_mouse_near_scrollbar_ = Layer::INVALID_ID; lets clear scroll_layer_id_when_mouse_over_scrollbar_ here too. https://codereview.chromium.org/2384053002/diff/140001/cc/trees/layer_tree_ho... cc/trees/layer_tree_host_impl.cc:3276: ? scroll_layer_id_when_mouse_near_scrollbar_ please add a DCHECK that they aren't both true.
Updated. PTAL. Thank you. https://codereview.chromium.org/2384053002/diff/140001/cc/trees/layer_tree_ho... File cc/trees/layer_tree_host_impl.cc (right): https://codereview.chromium.org/2384053002/diff/140001/cc/trees/layer_tree_ho... cc/trees/layer_tree_host_impl.cc:3236: scroll_layer_id_when_mouse_near_scrollbar_ = Layer::INVALID_ID; On 2016/10/05 12:32:11, bokan wrote: > lets clear scroll_layer_id_when_mouse_over_scrollbar_ here too. No, we need to record the old scroll_layer_id_when_mouse_over_scrollbar_ for mouse move out the scrollbar. https://cs.chromium.org/chromium/src/cc/trees/layer_tree_host_impl.cc?q=layer...
lgtm % nit https://codereview.chromium.org/2384053002/diff/140001/cc/trees/layer_tree_ho... File cc/trees/layer_tree_host_impl.cc (right): https://codereview.chromium.org/2384053002/diff/140001/cc/trees/layer_tree_ho... cc/trees/layer_tree_host_impl.cc:3236: scroll_layer_id_when_mouse_near_scrollbar_ = Layer::INVALID_ID; On 2016/10/05 13:55:32, chaopeng wrote: > On 2016/10/05 12:32:11, bokan wrote: > > lets clear scroll_layer_id_when_mouse_over_scrollbar_ here too. > > No, we need to record the old scroll_layer_id_when_mouse_over_scrollbar_ for > mouse move out the scrollbar. > https://cs.chromium.org/chromium/src/cc/trees/layer_tree_host_impl.cc?q=layer... Right, got it. Ok, it's fine as is. https://codereview.chromium.org/2384053002/diff/160001/cc/trees/layer_tree_ho... File cc/trees/layer_tree_host_impl.cc (right): https://codereview.chromium.org/2384053002/diff/160001/cc/trees/layer_tree_ho... cc/trees/layer_tree_host_impl.cc:3276: DCHECK(!(scroll_layer_id_when_mouse_near_scrollbar_ != Layer::INVALID_ID && This is more clearly expressed as: mouse_near_scrollbar == INVALID_ID || mouse_over_scrollbar == INVALID_ID
https://codereview.chromium.org/2384053002/diff/180001/cc/input/scrollbar_ani... File cc/input/scrollbar_animation_controller_thinning.cc (right): https://codereview.chromium.org/2384053002/diff/180001/cc/input/scrollbar_ani... cc/input/scrollbar_animation_controller_thinning.cc:137: void ScrollbarAnimationControllerThinning::DidMouseLeave() { This seems very similar to DidMouseMoveOffScrollbar, are the differences meaningful? Can't this just be deleted and the caller can use DidMouseMoveOffScrollbar instead? https://codereview.chromium.org/2384053002/diff/180001/ui/events/blink/web_in... File ui/events/blink/web_input_event.cc (right): https://codereview.chromium.org/2384053002/diff/180001/ui/events/blink/web_in... ui/events/blink/web_input_event.cc:405: #if defined(OS_CHROMEOS) Platform ifdefs are generally a bad practice, how hard is it to fix crbug.com/450631 or otherwise avoid an ifdef here?
https://codereview.chromium.org/2384053002/diff/180001/ui/events/blink/web_in... File ui/events/blink/web_input_event.cc (right): https://codereview.chromium.org/2384053002/diff/180001/ui/events/blink/web_in... ui/events/blink/web_input_event.cc:405: #if defined(OS_CHROMEOS) On 2016/10/07 02:09:51, aelias wrote: > Platform ifdefs are generally a bad practice, how hard is it to fix > crbug.com/450631 or otherwise avoid an ifdef here? aelias@ completely agree this ifdef is bad. We do need to fix 450631 and we are pushing lanwei to ensure that is done soon. But the ifdef is needed to unblock this bug and it is reasonable to do this ifdef instead of other work arounds.
CL updated. I also add reset scroll_layer_id_when_mouse_over_scrollbar_ when mouse move out of window. PTAL. Thank you. https://codereview.chromium.org/2384053002/diff/180001/cc/input/scrollbar_ani... File cc/input/scrollbar_animation_controller_thinning.cc (right): https://codereview.chromium.org/2384053002/diff/180001/cc/input/scrollbar_ani... cc/input/scrollbar_animation_controller_thinning.cc:137: void ScrollbarAnimationControllerThinning::DidMouseLeave() { On 2016/10/07 02:09:51, aelias wrote: > This seems very similar to DidMouseMoveOffScrollbar, are the differences > meaningful? Can't this just be deleted and the caller can use > DidMouseMoveOffScrollbar instead? Yes, I should use DidMouseMoveOffScrollbar.
Description was changed from ========== cancel overlay-scrollbar hover state when moving pointer out of window for ChromeOS For this bug convert ET_MOUSE_EXITED to MouseLeave in ChromeOS and make the scrollbar thin and light when we receive MouseLeave. For other platform, we will fix this bug after crbug.com/450631 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ========== to ========== cancel overlay-scrollbar hover state when moving pointer out of window for ChromeOS For this bug convert ET_MOUSE_EXITED to MouseLeave in ChromeOS and make the scrollbar thin and light when we receive MouseLeave. For other platform, we will fix this bug after crbug.com/450631 BUG=332227 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ==========
https://codereview.chromium.org/2384053002/diff/180001/ui/events/blink/web_in... File ui/events/blink/web_input_event.cc (right): https://codereview.chromium.org/2384053002/diff/180001/ui/events/blink/web_in... ui/events/blink/web_input_event.cc:405: #if defined(OS_CHROMEOS) On 2016/10/07 at 14:30:39, dtapuska wrote: > On 2016/10/07 02:09:51, aelias wrote: > > Platform ifdefs are generally a bad practice, how hard is it to fix > > crbug.com/450631 or otherwise avoid an ifdef here? > > aelias@ completely agree this ifdef is bad. We do need to fix 450631 and we are pushing lanwei to ensure that is done soon. But the ifdef is needed to unblock this bug and it is reasonable to do this ifdef instead of other work arounds. OK, fine since you're actively working on the fix. https://codereview.chromium.org/2384053002/diff/260001/cc/trees/layer_tree_ho... File cc/trees/layer_tree_host_impl.h (right): https://codereview.chromium.org/2384053002/diff/260001/cc/trees/layer_tree_ho... cc/trees/layer_tree_host_impl.h:750: int scroll_layer_id_when_mouse_near_scrollbar_; Why's this state needed? Can't you just loop through *all* scrollbar animators and call DidMouseMoveOffScrollbar on them instead? To avoid unnecessary work, I suggest making DidMouseMoveOffScrollbar avoid calling StartAnimation() if nothing changed.
https://codereview.chromium.org/2384053002/diff/260001/cc/trees/layer_tree_ho... File cc/trees/layer_tree_host_impl.h (right): https://codereview.chromium.org/2384053002/diff/260001/cc/trees/layer_tree_ho... cc/trees/layer_tree_host_impl.h:750: int scroll_layer_id_when_mouse_near_scrollbar_; On 2016/10/07 16:26:19, aelias wrote: > Why's this state needed? Can't you just loop through *all* scrollbar animators > and call DidMouseMoveOffScrollbar on them instead? > > To avoid unnecessary work, I suggest making DidMouseMoveOffScrollbar avoid > calling StartAnimation() if nothing changed. loop through *all* scrollbar animators is better idea. CL updated, PTAL. Thank you.
lgtm https://codereview.chromium.org/2384053002/diff/280001/cc/input/scrollbar_ani... File cc/input/scrollbar_animation_controller_thinning.cc (right): https://codereview.chromium.org/2384053002/diff/280001/cc/input/scrollbar_ani... cc/input/scrollbar_animation_controller_thinning.cc:85: if (mouse_is_over_scrollbar_ || mouse_is_near_scrollbar_) { Nit: preferred pattern is early-return (because this pattern causes extra indentation and braces, which can pile up) if (!mouse_is_over_scrollbar_ && !mouse_is_near_scrollbar_) return;
The CQ bit was checked by chaopeng@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dtapuska@chromium.org, bokan@chromium.org, aelias@chromium.org Link to the patchset: https://codereview.chromium.org/2384053002/#ps300001 (title: "quick return")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== cancel overlay-scrollbar hover state when moving pointer out of window for ChromeOS For this bug convert ET_MOUSE_EXITED to MouseLeave in ChromeOS and make the scrollbar thin and light when we receive MouseLeave. For other platform, we will fix this bug after crbug.com/450631 BUG=332227 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ========== to ========== cancel overlay-scrollbar hover state when moving pointer out of window for ChromeOS For this bug convert ET_MOUSE_EXITED to MouseLeave in ChromeOS and make the scrollbar thin and light when we receive MouseLeave. For other platform, we will fix this bug after crbug.com/450631 BUG=332227 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/351b1d8638edcf2ce37f6d89b0908313780e7dd6 Cr-Commit-Position: refs/heads/master@{#424530} ==========
Message was sent while issue was closed.
Patchset 16 (id:??) landed as https://crrev.com/351b1d8638edcf2ce37f6d89b0908313780e7dd6 Cr-Commit-Position: refs/heads/master@{#424530}
Message was sent while issue was closed.
Description was changed from ========== cancel overlay-scrollbar hover state when moving pointer out of window for ChromeOS For this bug convert ET_MOUSE_EXITED to MouseLeave in ChromeOS and make the scrollbar thin and light when we receive MouseLeave. For other platform, we will fix this bug after crbug.com/450631 BUG=332227 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/351b1d8638edcf2ce37f6d89b0908313780e7dd6 Cr-Commit-Position: refs/heads/master@{#424530} ========== to ========== cancel overlay-scrollbar hover state when moving pointer out of window for ChromeOS For this bug convert ET_MOUSE_EXITED to MouseLeave in ChromeOS and make the scrollbar thin and light when we receive MouseLeave. For other platform, we will fix this bug after crbug.com/450631 BUG=332227 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ==========
Message was sent while issue was closed.
Committed patchset #16 (id:300001)
Message was sent while issue was closed.
Description was changed from ========== cancel overlay-scrollbar hover state when moving pointer out of window for ChromeOS For this bug convert ET_MOUSE_EXITED to MouseLeave in ChromeOS and make the scrollbar thin and light when we receive MouseLeave. For other platform, we will fix this bug after crbug.com/450631 BUG=332227 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ========== to ========== cancel overlay-scrollbar hover state when moving pointer out of window for ChromeOS For this bug convert ET_MOUSE_EXITED to MouseLeave in ChromeOS and make the scrollbar thin and light when we receive MouseLeave. For other platform, we will fix this bug after crbug.com/450631 BUG=332227 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/3ba6cb3d9518e9a54f006fd6288438c211ba8998 Cr-Commit-Position: refs/heads/master@{#424531} ==========
Message was sent while issue was closed.
Patchset 16 (id:??) landed as https://crrev.com/3ba6cb3d9518e9a54f006fd6288438c211ba8998 Cr-Commit-Position: refs/heads/master@{#424531}
Message was sent while issue was closed.
A revert of this CL (patchset #16 id:300001) has been created in https://codereview.chromium.org/2406233004/ by alph@chromium.org. The reason for reverting is: Broke the build https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/26848.
Message was sent while issue was closed.
Description was changed from ========== cancel overlay-scrollbar hover state when moving pointer out of window for ChromeOS For this bug convert ET_MOUSE_EXITED to MouseLeave in ChromeOS and make the scrollbar thin and light when we receive MouseLeave. For other platform, we will fix this bug after crbug.com/450631 BUG=332227 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/3ba6cb3d9518e9a54f006fd6288438c211ba8998 Cr-Commit-Position: refs/heads/master@{#424531} ========== to ========== cancel overlay-scrollbar hover state when moving pointer out of window for ChromeOS For this bug convert ET_MOUSE_EXITED to MouseLeave in ChromeOS and make the scrollbar thin and light when we receive MouseLeave. For other platform, we will fix this bug after crbug.com/450631 BUG=332227 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/3ba6cb3d9518e9a54f006fd6288438c211ba8998 Cr-Commit-Position: refs/heads/master@{#424531} ==========
The CQ bit was checked by chaopeng@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== cancel overlay-scrollbar hover state when moving pointer out of window for ChromeOS For this bug convert ET_MOUSE_EXITED to MouseLeave in ChromeOS and make the scrollbar thin and light when we receive MouseLeave. For other platform, we will fix this bug after crbug.com/450631 BUG=332227 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/3ba6cb3d9518e9a54f006fd6288438c211ba8998 Cr-Commit-Position: refs/heads/master@{#424531} ========== to ========== cancel overlay-scrollbar hover state when moving pointer out of window for ChromeOS For this bug convert ET_MOUSE_EXITED to MouseLeave in ChromeOS and make the scrollbar thin and light when we receive MouseLeave. For other platform, we will fix this bug after crbug.com/450631 BUG=332227 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/3ba6cb3d9518e9a54f006fd6288438c211ba8998 Cr-Commit-Position: refs/heads/master@{#424531} ==========
Message was sent while issue was closed.
Committed patchset #16 (id:300001)
Message was sent while issue was closed.
Description was changed from ========== cancel overlay-scrollbar hover state when moving pointer out of window for ChromeOS For this bug convert ET_MOUSE_EXITED to MouseLeave in ChromeOS and make the scrollbar thin and light when we receive MouseLeave. For other platform, we will fix this bug after crbug.com/450631 BUG=332227 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/3ba6cb3d9518e9a54f006fd6288438c211ba8998 Cr-Commit-Position: refs/heads/master@{#424531} ========== to ========== cancel overlay-scrollbar hover state when moving pointer out of window for ChromeOS For this bug convert ET_MOUSE_EXITED to MouseLeave in ChromeOS and make the scrollbar thin and light when we receive MouseLeave. For other platform, we will fix this bug after crbug.com/450631 BUG=332227 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/3ba6cb3d9518e9a54f006fd6288438c211ba8998 Committed: https://crrev.com/fff2d5ac5578916345697e5612fa33e2f75a4dec Cr-Original-Commit-Position: refs/heads/master@{#424531} Cr-Commit-Position: refs/heads/master@{#425045} ==========
Message was sent while issue was closed.
Patchset 16 (id:??) landed as https://crrev.com/fff2d5ac5578916345697e5612fa33e2f75a4dec Cr-Commit-Position: refs/heads/master@{#425045} |