cancel overlay-scrollbar hover state when moving pointer out of window for ChromeOS

ui/events/blink/web_input_event.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/events/blink/web_input_event.h"
 
 #include "ui/events/base_event_utils.h"
 #include "ui/events/blink/blink_event_util.h"
 #include "ui/events/event.h"
 #include "ui/events/event_utils.h"
@@ skipping 381 matching lines @@
 
   switch (event.type()) {
     case ET_MOUSE_PRESSED:
       webkit_event.type = blink::WebInputEvent::MouseDown;
       webkit_event.clickCount = event.GetClickCount();
       break;
     case ET_MOUSE_RELEASED:
       webkit_event.type = blink::WebInputEvent::MouseUp;
       webkit_event.clickCount = event.GetClickCount();
       break;
+    case ET_MOUSE_EXITED:
+// TODO(chaopeng) this fix only for chromeos now, should convert ET_MOUSE_EXITED
+// to MouseLeave when crbug.com/450631 fixed.
+#if defined(OS_CHROMEOS)

[aelias_OOO_until_Jul13, 2016/10/07 02:09:51]

Platform ifdefs are generally a bad practice, how hard is it to fix
crbug.com/450631 or otherwise avoid an ifdef here?

[dtapuska, 2016/10/07 14:30:39]

aelias@ completely agree this ifdef is bad. We do need to fix 450631 and we are
pushing lanwei to ensure that is done soon. But the ifdef is needed to unblock
this bug and it is reasonable to do this ifdef instead of other work arounds.

[aelias_OOO_until_Jul13, 2016/10/07 16:26:19]

OK, fine since you're actively working on the fix.

+      webkit_event.type = blink::WebInputEvent::MouseLeave;
+      break;
+#endif
     case ET_MOUSE_ENTERED:
-    case ET_MOUSE_EXITED:
     case ET_MOUSE_MOVED:
     case ET_MOUSE_DRAGGED:
       webkit_event.type = blink::WebInputEvent::MouseMove;
       break;
     default:
       NOTIMPLEMENTED() << "Received unexpected event: " << event.type();
       break;
   }
 
   webkit_event.tiltX = roundf(event.pointer_details().tilt_x);
@@ skipping 23 matching lines @@
   webkit_event.tiltX = roundf(event.pointer_details().tilt_x);
   webkit_event.tiltY = roundf(event.pointer_details().tilt_y);
   webkit_event.force = event.pointer_details().force;
   webkit_event.pointerType =
       EventPointerTypeToWebPointerType(event.pointer_details().pointer_type);
 
   return webkit_event;
 }
 
 }  // namespace ui