Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: chrome/browser/apps/web_view_browsertest.cc

Issue 23840002: Disable WebViewTest.ClearData on WinXP. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/apps/web_view_browsertest.cc
diff --git a/chrome/browser/apps/web_view_browsertest.cc b/chrome/browser/apps/web_view_browsertest.cc
index 92c276703f308e8d9a162eb2a9fee0a12ee21798..67fcd965d867e58c1d404e7e8fcefeb79ee21d9d 100644
--- a/chrome/browser/apps/web_view_browsertest.cc
+++ b/chrome/browser/apps/web_view_browsertest.cc
@@ -1540,6 +1540,12 @@ IN_PROC_BROWSER_TEST_F(WebViewTest, GeolocationRequestGone) {
}
IN_PROC_BROWSER_TEST_F(WebViewTest, ClearData) {
+#if defined(OS_WIN)
+ // Flaky on XP bot http://crbug.com/282674
+ if (base::win::GetVersion() <= base::win::VERSION_XP)
Lambros 2013/08/30 23:07:35 nit: #include "base/win/windows_version.h" for Get
lazyboy 2013/08/30 23:15:31 Seems like it is already included.
Lambros 2013/08/30 23:19:56 I don't see it in this file in this CL. Transitive
lazyboy 2013/08/30 23:21:49 ^^^
+ return;
+#endif
+
ASSERT_TRUE(StartEmbeddedTestServer()); // For serving guest pages.
ASSERT_TRUE(RunPlatformAppTestWithArg(
"platform_apps/web_view/common", "cleardata"))
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698