Disable WebViewTest.ClearData on WinXP.

chrome/browser/apps/web_view_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "apps/native_app_window.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/apps/app_browsertest_util.h"
 #include "chrome/browser/automation/automation_util.h"
 #include "chrome/browser/extensions/extension_test_message_listener.h"
@@ skipping 11 matching lines @@
 #include "content/public/browser/web_contents_delegate.h"
 #include "content/public/test/browser_test_utils.h"
 #include "content/public/test/fake_speech_recognition_manager.h"
 #include "net/test/embedded_test_server/embedded_test_server.h"
 #include "net/test/embedded_test_server/http_request.h"
 #include "net/test/embedded_test_server/http_response.h"
 #include "ui/gl/gl_switches.h"
 
 // For fine-grained suppression on flaky tests.
 #if defined(OS_WIN)
 #include "base/win/windows_version.h"

[lazyboy, 2013/08/30 23:21:49]

Here.

 #endif
 
 using prerender::PrerenderLinkManager;
 using prerender::PrerenderLinkManagerFactory;
 
 namespace {
 const char kEmptyResponsePath[] = "/close-socket";
 const char kRedirectResponsePath[] = "/server-redirect";
 const char kRedirectResponseFullPath[] =
     "/extensions/platform_apps/web_view/shim/guest_redirect.html";
@@ skipping 1490 matching lines @@
 }
 
 IN_PROC_BROWSER_TEST_F(WebViewTest, GeolocationRequestGone) {
   ASSERT_TRUE(StartEmbeddedTestServer());  // For serving guest pages.
   ASSERT_TRUE(RunPlatformAppTest(
         "platform_apps/web_view/geolocation/geolocation_request_gone"))
             << message_;
 }
 
 IN_PROC_BROWSER_TEST_F(WebViewTest, ClearData) {
+#if defined(OS_WIN)
+  // Flaky on XP bot http://crbug.com/282674
+  if (base::win::GetVersion() <= base::win::VERSION_XP)

[Lambros, 2013/08/30 23:07:35]

nit: #include "base/win/windows_version.h" for GetVersion().

[lazyboy, 2013/08/30 23:15:31]

Seems like it is already included.

[Lambros, 2013/08/30 23:19:56]

I don't see it in this file in this CL. Transitive #inclusion is generally
frowned upon, see:
https://code.google.com/p/chromium/wiki/IncludeWhatYouUse

[lazyboy, 2013/08/30 23:21:49]

^^^

+    return;
+#endif
+
   ASSERT_TRUE(StartEmbeddedTestServer());  // For serving guest pages.
   ASSERT_TRUE(RunPlatformAppTestWithArg(
       "platform_apps/web_view/common", "cleardata"))
           << message_;
 }
 
 IN_PROC_BROWSER_TEST_F(WebViewTest, ConsoleMessage) {
   ASSERT_TRUE(StartEmbeddedTestServer());  // For serving guest pages.
   ASSERT_TRUE(RunPlatformAppTestWithArg(
       "platform_apps/web_view/common", "console_messages"))
@@ skipping 99 matching lines @@
              "DoneDialogTest.FAILED",
              "web_view/dialog");
 }
 
 IN_PROC_BROWSER_TEST_F(WebViewTest, Dialog_TestPromptDialog) {
   TestHelper("testPromptDialog",
              "DoneDialogTest.PASSED",
              "DoneDialogTest.FAILED",
              "web_view/dialog");
 }