Issue 2383953002: [Bootstrapping] Introduce an accelerator to put a ChromeOS device into Slave OOBE process.

xdai1

Patchset #1 (id:1) has been deleted

4 years, 2 months ago (2016-10-01 00:04:40 UTC) #1

xdai1

Description was changed from ========== [Bootstrapping] Introduce accelerators to put a ChromeOS device into Master/Slave ...

4 years, 2 months ago (2016-10-01 00:05:42 UTC) #2

Description was changed from

==========
[Bootstrapping] Introduce accelerators to put a ChromeOS device into
Master/Slave OOBE process.

In order to enhance the security and avoid the Bluetooth in-middle attach
between
Master and Slave, we've decided to do the followings for a Slave device:
- For devices lacking sufficient input, e.g., Chromebit, keep the state as it is
today:
  - The ChromeOS device will put itself in Bluetooth discoverable mode in the
first
    OOBE screen (HID detection screen) and accpet the incoming connection
request
    from the Bootstrapping app.
- For devices with sufficient input, e.g., Chromebook:
  - The ChromeOS device will have Bluetooth disabled by default as in normal
OOBE flow
  - Upon the user pressing the accelerator (Ctrl+Alt+Shift+S) in the first OOBE
screen
    (Network screen): the device will put itself in Bluetooth discoveralbe mode
and
    accept the incoming connection request from the Bootstrapping app.

We also introduce an accelerator for a Master device (Ctrl+Alt+Shift+M) as an
alternative
way to put itself in Master OOBE process.

BUG=652003
==========

to

==========
[Bootstrapping] Introduce an accelerator to put a ChromeOS device into Slave
OOBE process.

In order to enhance the security and avoid the Bluetooth in-middle attach
between
Master and Slave, we've decided to do the followings for a Slave device:
- For devices lacking sufficient input, e.g., Chromebit, keep the state as it is
today:
  - The ChromeOS device will put itself in Bluetooth discoverable mode in the
first
    OOBE screen (HID detection screen) and accpet the incoming connection
request
    from the Bootstrapping app.
- For devices with sufficient input, e.g., Chromebook:
  - The ChromeOS device will have Bluetooth disabled by default as in normal
OOBE flow
  - Upon the user pressing the accelerator (Ctrl+Alt+Shift+S) in the first OOBE
screen
    (Network screen): the device will put itself in Bluetooth discoveralbe mode
and
    accept the incoming connection request from the Bootstrapping app.

BUG=652003
==========

xdai1

The CQ bit was checked by xdai@chromium.org to run a CQ dry run

4 years, 2 months ago (2016-10-01 00:19:22 UTC) #3

xdai1

xdai@chromium.org changed reviewers: + achuith@chromium.org

4 years, 2 months ago (2016-10-01 00:19:53 UTC) #4

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383953002/40001

4 years, 2 months ago (2016-10-01 00:19:55 UTC) #6

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 2 months ago (2016-10-01 01:25:59 UTC) #7

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/287868)

4 years, 2 months ago (2016-10-01 01:26:00 UTC) #8

achuithb

Where are you differentiating between Chromebits and other devices? https://codereview.chromium.org/2383953002/diff/40001/chrome/browser/chromeos/login/wizard_controller.cc File chrome/browser/chromeos/login/wizard_controller.cc (right): https://codereview.chromium.org/2383953002/diff/40001/chrome/browser/chromeos/login/wizard_controller.cc#newcode112 chrome/browser/chromeos/login/wizard_controller.cc:112: ...

4 years, 2 months ago (2016-10-01 16:49:18 UTC) #9

xdai1

achuith@, I've addressed your comments. Please take another look, thanks! https://codereview.chromium.org/2383953002/diff/40001/chrome/browser/chromeos/login/wizard_controller.cc File chrome/browser/chromeos/login/wizard_controller.cc (right): https://codereview.chromium.org/2383953002/diff/40001/chrome/browser/chromeos/login/wizard_controller.cc#newcode113 ...

4 years, 2 months ago (2016-10-03 21:08:00 UTC) #10

achuithb

https://codereview.chromium.org/2383953002/diff/60001/chrome/browser/chromeos/login/bluetooth_host_pairing_browsertest.cc File chrome/browser/chromeos/login/bluetooth_host_pairing_browsertest.cc (right): https://codereview.chromium.org/2383953002/diff/60001/chrome/browser/chromeos/login/bluetooth_host_pairing_browsertest.cc#newcode51 chrome/browser/chromeos/login/bluetooth_host_pairing_browsertest.cc:51: class BluetoothHostPairingTestNoInput : public OobeBaseTest { Isn't BluetoothHostPairingNoInputTest better? ...

4 years, 2 months ago (2016-10-05 22:24:10 UTC) #12

xdai1

achuith@, I've addressed your comments. Please take another look, thanks! https://codereview.chromium.org/2383953002/diff/60001/chrome/browser/chromeos/login/bluetooth_host_pairing_browsertest.cc File chrome/browser/chromeos/login/bluetooth_host_pairing_browsertest.cc (right): https://codereview.chromium.org/2383953002/diff/60001/chrome/browser/chromeos/login/bluetooth_host_pairing_browsertest.cc#newcode51 ...

4 years, 2 months ago (2016-10-05 23:57:29 UTC) #13

achuithb

lgtm with the following renames https://codereview.chromium.org/2383953002/diff/80001/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc File chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc (right): https://codereview.chromium.org/2383953002/diff/80001/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc#newcode164 chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc:164: AddCallback("setOobeBootstrappingRole", setBootstrappingSlave https://codereview.chromium.org/2383953002/diff/80001/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.h File ...

4 years, 2 months ago (2016-10-06 18:25:34 UTC) #14

xdai1

Comments addressed. Thanks for your review! https://codereview.chromium.org/2383953002/diff/80001/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.h File chrome/browser/ui/webui/chromeos/login/core_oobe_handler.h (right): https://codereview.chromium.org/2383953002/diff/80001/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.h#newcode146 chrome/browser/ui/webui/chromeos/login/core_oobe_handler.h:146: void HandleSetOobeBootstrappingRole(); On ...

4 years, 2 months ago (2016-10-06 21:49:11 UTC) #15

xdai1

Description was changed from ========== [Bootstrapping] Introduce an accelerator to put a ChromeOS device into ...

4 years, 2 months ago (2016-10-06 21:58:15 UTC) #16

Description was changed from

==========
[Bootstrapping] Introduce an accelerator to put a ChromeOS device into Slave
OOBE process.

In order to enhance the security and avoid the Bluetooth in-middle attach
between
Master and Slave, we've decided to do the followings for a Slave device:
- For devices lacking sufficient input, e.g., Chromebit, keep the state as it is
today:
  - The ChromeOS device will put itself in Bluetooth discoverable mode in the
first
    OOBE screen (HID detection screen) and accpet the incoming connection
request
    from the Bootstrapping app.
- For devices with sufficient input, e.g., Chromebook:
  - The ChromeOS device will have Bluetooth disabled by default as in normal
OOBE flow
  - Upon the user pressing the accelerator (Ctrl+Alt+Shift+S) in the first OOBE
screen
    (Network screen): the device will put itself in Bluetooth discoveralbe mode
and
    accept the incoming connection request from the Bootstrapping app.

BUG=652003
==========

to

==========
[Bootstrapping] Introduce an accelerator (Ctrl+Alt+Shift+S) to put a ChromeOS
device into Slave OOBE process.

In order to enhance the security and avoid the Bluetooth in-middle attach
between
Master and Slave, we've decided to do the followings for a Slave device:
- For devices lacking sufficient input, e.g., Chromebit, keep the state as it is
today:
  - The ChromeOS device will put itself in Bluetooth discoverable mode in the
first
    OOBE screen (HID detection screen) and accpet the incoming connection
request
    from the Bootstrapping app.
- For devices with sufficient input, e.g., Chromebook:
  - The ChromeOS device will have Bluetooth disabled by default as in normal
OOBE flow
  - Upon the user pressing the accelerator (Ctrl+Alt+Shift+S) in the first OOBE
screen
    (Network screen): the device will put itself in Bluetooth discoveralbe mode
and
    accept the incoming connection request from the Bootstrapping app.

BUG=652003
==========

xdai1

The patchset sent to the CQ was uploaded after l-g-t-m from achuith@chromium.org Link to the ...

4 years, 2 months ago (2016-10-06 21:58:22 UTC) #18

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383953002/100001

4 years, 2 months ago (2016-10-06 21:59:13 UTC) #19

commit-bot: I haz the power

Description was changed from ========== [Bootstrapping] Introduce an accelerator (Ctrl+Alt+Shift+S) to put a ChromeOS device ...

4 years, 2 months ago (2016-10-06 22:52:56 UTC) #20

Message was sent while issue was closed.

Description was changed from

==========
[Bootstrapping] Introduce an accelerator (Ctrl+Alt+Shift+S) to put a ChromeOS
device into Slave OOBE process.

In order to enhance the security and avoid the Bluetooth in-middle attach
between
Master and Slave, we've decided to do the followings for a Slave device:
- For devices lacking sufficient input, e.g., Chromebit, keep the state as it is
today:
  - The ChromeOS device will put itself in Bluetooth discoverable mode in the
first
    OOBE screen (HID detection screen) and accpet the incoming connection
request
    from the Bootstrapping app.
- For devices with sufficient input, e.g., Chromebook:
  - The ChromeOS device will have Bluetooth disabled by default as in normal
OOBE flow
  - Upon the user pressing the accelerator (Ctrl+Alt+Shift+S) in the first OOBE
screen
    (Network screen): the device will put itself in Bluetooth discoveralbe mode
and
    accept the incoming connection request from the Bootstrapping app.

BUG=652003
==========

to

==========
[Bootstrapping] Introduce an accelerator (Ctrl+Alt+Shift+S) to put a ChromeOS
device into Slave OOBE process.

In order to enhance the security and avoid the Bluetooth in-middle attach
between
Master and Slave, we've decided to do the followings for a Slave device:
- For devices lacking sufficient input, e.g., Chromebit, keep the state as it is
today:
  - The ChromeOS device will put itself in Bluetooth discoverable mode in the
first
    OOBE screen (HID detection screen) and accpet the incoming connection
request
    from the Bootstrapping app.
- For devices with sufficient input, e.g., Chromebook:
  - The ChromeOS device will have Bluetooth disabled by default as in normal
OOBE flow
  - Upon the user pressing the accelerator (Ctrl+Alt+Shift+S) in the first OOBE
screen
    (Network screen): the device will put itself in Bluetooth discoveralbe mode
and
    accept the incoming connection request from the Bootstrapping app.

BUG=652003
==========

commit-bot: I haz the power

Description was changed from ========== [Bootstrapping] Introduce an accelerator (Ctrl+Alt+Shift+S) to put a ChromeOS device ...

4 years, 2 months ago (2016-10-06 22:56:26 UTC) #22

Message was sent while issue was closed.

Description was changed from

==========
[Bootstrapping] Introduce an accelerator (Ctrl+Alt+Shift+S) to put a ChromeOS
device into Slave OOBE process.

In order to enhance the security and avoid the Bluetooth in-middle attach
between
Master and Slave, we've decided to do the followings for a Slave device:
- For devices lacking sufficient input, e.g., Chromebit, keep the state as it is
today:
  - The ChromeOS device will put itself in Bluetooth discoverable mode in the
first
    OOBE screen (HID detection screen) and accpet the incoming connection
request
    from the Bootstrapping app.
- For devices with sufficient input, e.g., Chromebook:
  - The ChromeOS device will have Bluetooth disabled by default as in normal
OOBE flow
  - Upon the user pressing the accelerator (Ctrl+Alt+Shift+S) in the first OOBE
screen
    (Network screen): the device will put itself in Bluetooth discoveralbe mode
and
    accept the incoming connection request from the Bootstrapping app.

BUG=652003
==========

to

==========
[Bootstrapping] Introduce an accelerator (Ctrl+Alt+Shift+S) to put a ChromeOS
device into Slave OOBE process.

In order to enhance the security and avoid the Bluetooth in-middle attach
between
Master and Slave, we've decided to do the followings for a Slave device:
- For devices lacking sufficient input, e.g., Chromebit, keep the state as it is
today:
  - The ChromeOS device will put itself in Bluetooth discoverable mode in the
first
    OOBE screen (HID detection screen) and accpet the incoming connection
request
    from the Bootstrapping app.
- For devices with sufficient input, e.g., Chromebook:
  - The ChromeOS device will have Bluetooth disabled by default as in normal
OOBE flow
  - Upon the user pressing the accelerator (Ctrl+Alt+Shift+S) in the first OOBE
screen
    (Network screen): the device will put itself in Bluetooth discoveralbe mode
and
    accept the incoming connection request from the Bootstrapping app.

BUG=652003

Committed: https://crrev.com/ee4b4ddc4c4fe256caa19b23d13358eec6740da0
Cr-Commit-Position: refs/heads/master@{#423718}
==========

commit-bot: I haz the power

4 years, 2 months ago (2016-10-06 22:56:28 UTC) #23

Message was sent while issue was closed.

Patchset 5 (id:??) landed as
https://crrev.com/ee4b4ddc4c4fe256caa19b23d13358eec6740da0
Cr-Commit-Position: refs/heads/master@{#423718}

Issue 2383953002: [Bootstrapping] Introduce an accelerator to put a ChromeOS device into Slave OOBE process. (Closed)

Description

Patch Set 1 : . #

Patch Set 2 : Only add acclerator for the Slave device. #

Patch Set 3 : Address the comments. #

Patch Set 4 : Address achuith@'s comments. #

Patch Set 5 : Address achuith@'s comments. #

Messages