[Bootstrapping] Introduce an accelerator to put a ChromeOS device into Slave OOBE process.

chrome/browser/chromeos/login/wizard_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/wizard_controller.h"
 
 #include <signal.h>
 #include <stddef.h>
 #include <stdlib.h>
 #include <sys/types.h>
@@ skipping 91 matching lines @@
 // Stores the list of all screens that should be shown when resuming OOBE.
 const char *kResumableScreens[] = {
   chromeos::WizardController::kNetworkScreenName,
   chromeos::WizardController::kUpdateScreenName,
   chromeos::WizardController::kEulaScreenName,
   chromeos::WizardController::kEnrollmentScreenName,
   chromeos::WizardController::kTermsOfServiceScreenName,
   chromeos::WizardController::kAutoEnrollmentCheckScreenName
 };
 
+// the role of a "slave" device in the OOBE bootstrapping process.

[achuithb, 2016/10/01 16:49:17]

s/the/The

+const char kOobeBootstrappingSlave[] = "slave";

[achuithb, 2016/10/01 16:49:17]

Is this the only possible value? Why not have a boolean instead?

[xdai1, 2016/10/03 21:08:00]

You're right. Since we don't need an accelerator for the master device, I should
only need a boolean here. Modified as you suggested.

+
 // Checks flag for HID-detection screen show.
 bool CanShowHIDDetectionScreen() {
   return !base::CommandLine::ForCurrentProcess()->HasSwitch(
       chromeos::switches::kDisableHIDDetectionOnOOBE);
 }
 
 bool IsResumableScreen(const std::string& screen) {
   for (size_t i = 0; i < arraysize(kResumableScreens); ++i) {
     if (screen == kResumableScreens[i])
       return true;
@@ skipping 37 matching lines @@
   return g_browser_process->local_state()->GetBoolean(
       prefs::kOobeControllerDetected);
 }
 
 void SetControllerDetectedPref(bool value) {
   PrefService* prefs = g_browser_process->local_state();
   prefs->SetBoolean(prefs::kOobeControllerDetected, value);
   prefs->CommitPendingWrite();
 }
 
+// Checks if the device is a "slave" device in the bootstrapping process.
+bool IsBootstrappingSlave() {
+  return g_browser_process->local_state()->GetString(
+             prefs::kOobeBootstrappingRole) == kOobeBootstrappingSlave;
+}
+
 // Checks if the device is a "Master" device in the bootstrapping process.
 bool IsBootstrappingMaster() {
   return base::CommandLine::ForCurrentProcess()->HasSwitch(
       chromeos::switches::kOobeBootstrappingMaster);
 }
 
 bool NetworkAllowUpdate(const chromeos::NetworkState* network) {
   if (!network || !network->IsConnectedState())
     return false;
   if (network->type() == shill::kTypeBluetooth ||
@@ skipping 244 matching lines @@
   return nullptr;
 }
 
 void WizardController::ShowNetworkScreen() {
   VLOG(1) << "Showing network screen.";
   // Hide the status area initially; it only appears after OOBE first animates
   // in. Keep it visible if the user goes back to the existing network screen.
   SetStatusAreaVisible(HasScreen(kNetworkScreenName));
   SetCurrentScreen(GetScreen(kNetworkScreenName));
 
-  MaybeStartListeningForSharkConnection();
+  if (IsBootstrappingSlave())
+    MaybeStartListeningForSharkConnection();
 }
 
 void WizardController::ShowLoginScreen(const LoginScreenContext& context) {
   // This may be triggered by multiply asynchronous events from the JS side.
   if (login_screen_started_)
     return;
 
   if (!time_eula_accepted_.is_null()) {
     base::TimeDelta delta = base::Time::Now() - time_eula_accepted_;
     UMA_HISTOGRAM_MEDIUM_TIMES("OOBE.EULAToSignInTime", delta);
@@ skipping 987 matching lines @@
             : policy::EnrollmentConfig::MODE_MANUAL_REENROLLMENT;
   }
 
   EnrollmentScreen* screen = EnrollmentScreen::Get(this);
   screen->SetParameters(effective_config, shark_controller_.get());
   SetStatusAreaVisible(true);
   SetCurrentScreen(screen);
 }
 
 }  // namespace chromeos