third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.cpp - Issue 2383613003: Remove 'V8' prefix from generated callback function classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.cpp

Issue 2383613003: Remove 'V8' prefix from generated callback function classes (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.h ('k') | third_party/WebKit/Source/bindings/tests/results/core/VoidExperimentalCallbackFunction.h » ('j') | third_party/WebKit/Source/core/timing/PerformanceObserver.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8VoidCallbackFunctionInterfaceArg.cpp b/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.cpp

similarity index 81%

rename from third_party/WebKit/Source/bindings/tests/results/core/V8VoidCallbackFunctionInterfaceArg.cpp

rename to third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.cpp

index 3e707244b5fdbe6fe382846f74c19ff9acf39abf..45027382d18eebcad33afe9ebf93ea214b25bd52 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8VoidCallbackFunctionInterfaceArg.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.cpp

@@ -6,7 +6,7 @@

// clang-format off

-#include "V8VoidCallbackFunctionInterfaceArg.h"

+#include "VoidCallbackFunctionInterfaceArg.h"

#include "bindings/core/v8/ScriptState.h"

#include "bindings/core/v8/ToV8.h"

@@ -17,18 +17,18 @@

namespace blink {

-V8VoidCallbackFunctionInterfaceArg::V8VoidCallbackFunctionInterfaceArg(v8::Isolate* isolate, v8::Local<v8::Function> callback)

+VoidCallbackFunctionInterfaceArg::VoidCallbackFunctionInterfaceArg(v8::Isolate* isolate, v8::Local<v8::Function> callback)

: m_callback(isolate, callback)

{

DCHECK(!m_callback.isEmpty());

m_callback.setPhantom();

}

-DEFINE_TRACE(V8VoidCallbackFunctionInterfaceArg)

+DEFINE_TRACE(VoidCallbackFunctionInterfaceArg)

{

}

-bool V8VoidCallbackFunctionInterfaceArg::call(ScriptState* scriptState, ScriptWrappable* scriptWrappable, ExceptionState& exceptionState, HTMLDivElement* divElement)

+bool VoidCallbackFunctionInterfaceArg::call(ScriptState* scriptState, ScriptWrappable* scriptWrappable, ExceptionState& exceptionState, HTMLDivElement* divElement)

{

if (!scriptState->contextIsValid())

return false;