Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1604)

Unified Diff: third_party/WebKit/Source/core/timing/PerformanceObserver.h

Issue 2383613003: Remove 'V8' prefix from generated callback function classes (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/timing/PerformanceObserver.h
diff --git a/third_party/WebKit/Source/core/timing/PerformanceObserver.h b/third_party/WebKit/Source/core/timing/PerformanceObserver.h
index cbe27a0ee3e63b68a447b1cf0995486b86d89b5f..52f1c8cbe6f0bad640719f2f8413b72ef7710978 100644
--- a/third_party/WebKit/Source/core/timing/PerformanceObserver.h
+++ b/third_party/WebKit/Source/core/timing/PerformanceObserver.h
@@ -18,7 +18,7 @@ class PerformanceBase;
class PerformanceObserver;
class PerformanceObserverInit;
class ScriptState;
-class V8PerformanceObserverCallback;
+class PerformanceObserverCallback;
peria 2016/09/30 07:31:44 alphabetical order
bashi 2016/09/30 07:53:57 Done.
using PerformanceEntryVector = HeapVector<Member<PerformanceEntry>>;
@@ -27,7 +27,7 @@ class CORE_EXPORT PerformanceObserver final : public GarbageCollectedFinalized<P
friend class PerformanceBase;
friend class PerformanceObserverTest;
public:
- static PerformanceObserver* create(ScriptState*, PerformanceBase*, V8PerformanceObserverCallback*);
+ static PerformanceObserver* create(ScriptState*, PerformanceBase*, PerformanceObserverCallback*);
static void resumeSuspendedObservers();
void observe(const PerformanceObserverInit&, ExceptionState&);
@@ -38,12 +38,12 @@ public:
DECLARE_TRACE();
private:
- PerformanceObserver(ScriptState*, PerformanceBase*, V8PerformanceObserverCallback*);
+ PerformanceObserver(ScriptState*, PerformanceBase*, PerformanceObserverCallback*);
void deliver();
bool shouldBeSuspended() const;
RefPtr<ScriptState> m_scriptState;
- Member<V8PerformanceObserverCallback> m_callback;
+ Member<PerformanceObserverCallback> m_callback;
WeakMember<PerformanceBase> m_performance;
PerformanceEntryVector m_performanceEntries;
PerformanceEntryTypeMask m_filterOptions;

Powered by Google App Engine
This is Rietveld 408576698