Issue 23835016: Clear the usage of useBrowserOverlays from PrintWebViewHelper and PrepareFrameAndViewForPrint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23835016: Clear the usage of useBrowserOverlays from PrintWebViewHelper and PrepareFrameAndViewForPrint (Closed)

Created:
7 years, 3 months ago by vivekg_samsung

Modified:
7 years, 3 months ago

Reviewers:
vivekg__, Vitaly Buka (NO REVIEWS), abarth-chromium

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Clear the usage of useBrowserOverlays from PrintWebViewHelper and PrepareFrameAndViewForPrint As per https://codereview.chromium.org/11953010/, chromium is no longer using the useBrowserOverlays. Also the bug https://bugs.webkit.org/show_bug.cgi?id=107718 marks the removal of the same. Patch authored by vivek.vg@samsung.com. R=vitalybuka@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224321

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -5 lines)			Patch
		chrome/renderer/printing/print_web_view_helper.cc	View		3 chunks	+3 lines, -5 lines	0 comments	Download

Total messages: 4 (0 generated)

vivekg__

Created blink side changes for removal of the useBrowserOverlay from WebFrame: https://codereview.chromium.org/24304003/

7 years, 3 months ago (2013-09-20 01:16:42 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/23835016/1

7 years, 3 months ago (2013-09-20 05:16:21 UTC) #3

Mike West

7 years, 3 months ago (2013-09-20 07:19:27 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r224321 (presubmit successful).