Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: chrome/renderer/printing/print_web_view_helper.cc

Issue 23835016: Clear the usage of useBrowserOverlays from PrintWebViewHelper and PrepareFrameAndViewForPrint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/printing/print_web_view_helper.cc
diff --git a/chrome/renderer/printing/print_web_view_helper.cc b/chrome/renderer/printing/print_web_view_helper.cc
index b5bca337b2627ebcd28dbe5c505f2270fababec0..6db72c7707b6be3b2dd15fb1cebb20fc2e4c7af1 100644
--- a/chrome/renderer/printing/print_web_view_helper.cc
+++ b/chrome/renderer/printing/print_web_view_helper.cc
@@ -478,7 +478,7 @@ void PrintWebViewHelper::PrintHeaderAndFooter(
WebKit::WebPrintParams webkit_params(page_size);
webkit_params.printerDPI = GetDPI(&params);
- frame->printBegin(webkit_params, WebKit::WebNode(), NULL);
+ frame->printBegin(webkit_params);
frame->printPage(0, canvas);
frame->printEnd();
@@ -599,7 +599,7 @@ PrepareFrameAndViewForPrint::PrepareFrameAndViewForPrint(
print_params.print_scaling_option ==
WebKit::WebPrintScalingOptionFitToPrintableArea;
ComputeWebKitPrintParamsInDesiredDpi(params, &web_print_params_);
- frame->printBegin(web_print_params_, node_to_print_, NULL);
+ frame->printBegin(web_print_params_, node_to_print_);
print_params = CalculatePrintParamsForCss(frame, 0, print_params,
ignore_css_margins, fit_to_page,
NULL);
@@ -639,10 +639,8 @@ void PrepareFrameAndViewForPrint::StartPrinting() {
ResizeForPrinting();
WebKit::WebView* web_view = frame_.view();
web_view->settings()->setShouldPrintBackgrounds(should_print_backgrounds_);
- // TODO(vitalybuka): Update call after
- // https://bugs.webkit.org/show_bug.cgi?id=107718 is fixed.
expected_pages_count_ =
- frame()->printBegin(web_print_params_, node_to_print_, NULL);
+ frame()->printBegin(web_print_params_, node_to_print_);
is_printing_started_ = true;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698