chrome/browser/devtools/devtools_window.h - Issue 23835007: DevTools: Do not close devtools if there are dirty files in workspace

Unified Diff: chrome/browser/devtools/devtools_window.h

Issue 23835007: DevTools: Do not close devtools if there are dirty files in workspace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix win compile Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/devtools/devtools_window.h

diff --git a/chrome/browser/devtools/devtools_window.h b/chrome/browser/devtools/devtools_window.h

index 32c3d71b26bd23872dd77c971c13ab0efffab4ad..a9d7bcc9d305b674bb242b45c35a349ff04e1a6e 100644

--- a/chrome/browser/devtools/devtools_window.h

+++ b/chrome/browser/devtools/devtools_window.h

@@ -130,6 +130,14 @@ class DevToolsWindow : private content::NotificationObserver,

void Show(const DevToolsToggleAction& action);

+ static bool HandleBeforeUnload(content::WebContents*, bool, bool*);

jeremy 2013/11/07 14:18:34 This needs a comment, how about something like: I

jeremy 2013/11/07 14:18:34 Why no variable names in header? Also, these func

lushnikov 2013/11/07 17:18:10 Done.

+ static bool InterceptPageBeforeUnload(content::WebContents*);

+ static bool ShouldCloseDevToolsBrowser(Browser*);

+ static bool NeedToFireBeforeUnload(content::WebContents*);

+ static void PageClosingCanceled(content::WebContents*);

+ void SetDockSideForTest(DevToolsDockSide dock_side);

private:

friend class DevToolsControllerTest;

@@ -281,6 +289,7 @@ class DevToolsWindow : private content::NotificationObserver,

int width_;

int height_;

DevToolsDockSide dock_side_before_minimized_;

+ bool inspected_page_is_closing_;

scoped_ptr<DevToolsEmbedderMessageDispatcher> embedder_message_dispatcher_;

base::WeakPtrFactory<DevToolsWindow> weak_factory_;