DevTools: Do not close devtools if there are dirty files in workspace

chrome/browser/devtools/devtools_window.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_
 #define CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 112 matching lines @@
   int GetHeight(int container_height);
 
   // Stores preferred devtools window width for this instance.
   void SetWidth(int width);
 
   // Stores preferred devtools window height for this instance.
   void SetHeight(int height);
 
   void Show(const DevToolsToggleAction& action);
 
+  static bool HandleBeforeUnload(content::WebContents*, bool, bool*);

[jeremy, 2013/11/07 14:18:34]

This needs a comment, how about something like:

In order to preserve any edits the user may have made in devtools, the
beforeunload event is hooked - devtools gets the first shot at handling
beforeunload and presents a dialog to the user, if the user accepts the dialog
then the script is given a chance to handle it i.e. 2 dialogs may be displayed:
one from the devtools asking the user to confirm that they're ok with their
edits going away and another from the webpage as the result of it's beforeunload
handler.

[jeremy, 2013/11/07 14:18:34]

Why no variable names in header?  Also, these functions need comments...

[lushnikov, 2013/11/07 17:18:10]

Done.

[lushnikov, 2013/11/07 17:18:10]

Done.

+  static bool InterceptPageBeforeUnload(content::WebContents*);
+  static bool ShouldCloseDevToolsBrowser(Browser*);
+  static bool NeedToFireBeforeUnload(content::WebContents*);
+  static void PageClosingCanceled(content::WebContents*);
+
+  void SetDockSideForTest(DevToolsDockSide dock_side);
+
  private:
   friend class DevToolsControllerTest;
 
   DevToolsWindow(Profile* profile,
                  const GURL& frontend_url,
                  content::RenderViewHost* inspected_rvh,
                  DevToolsDockSide dock_side);
 
   static DevToolsWindow* Create(Profile* profile,
                                 const GURL& frontend_url,
@@ skipping 131 matching lines @@
   scoped_ptr<DevToolsFileHelper> file_helper_;
   scoped_refptr<DevToolsFileSystemIndexer> file_system_indexer_;
   typedef std::map<
       int,
       scoped_refptr<DevToolsFileSystemIndexer::FileSystemIndexingJob> >
       IndexingJobsMap;
   IndexingJobsMap indexing_jobs_;
   int width_;
   int height_;
   DevToolsDockSide dock_side_before_minimized_;
+  bool inspected_page_is_closing_;
 
   scoped_ptr<DevToolsEmbedderMessageDispatcher> embedder_message_dispatcher_;
   base::WeakPtrFactory<DevToolsWindow> weak_factory_;
   DISALLOW_COPY_AND_ASSIGN(DevToolsWindow);
 };
 
 #endif  // CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_