third_party/WebKit/public/web/WebView.h - Issue 2383473002: [scheduler] Teach scheduler about audio state

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/web/WebView.h

Issue 2383473002: [scheduler] Teach scheduler about audio state (Closed)

Patch Set: Switched approach to use WebContentsImpl::WasRecentlyAudible Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/public/web/WebView.h

diff --git a/third_party/WebKit/public/web/WebView.h b/third_party/WebKit/public/web/WebView.h

index 89a958247bb9dacdf37ea604cbc04addbc106883..395e181f0460e29596a4420761ece658354eb0b8 100644

--- a/third_party/WebKit/public/web/WebView.h

+++ b/third_party/WebKit/public/web/WebView.h

@@ -357,6 +357,8 @@ public:

virtual void performPluginAction(

const WebPluginAction&, const WebPoint& location) = 0;

+ // Notifies WebView about audio is started or stopped.

Sami 2016/10/03 14:36:32 s/about/when/?

altimin 2016/10/03 15:53:39 Done.

+ virtual void audioStateChanged(bool isAudioPlaying) = 0;

Sami 2016/10/03 14:36:32 nit: Could we be consistent about isAudioPlaying/i

altimin 2016/10/03 15:53:39 Sorry, it was the last typo in WebSchedulerImpl.

// Data exchange -------------------------------------------------------