Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Side by Side Diff: third_party/WebKit/public/web/WebView.h

Issue 2383473002: [scheduler] Teach scheduler about audio state (Closed)
Patch Set: Switched approach to use WebContentsImpl::WasRecentlyAudible Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2010, 2011, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2009, 2010, 2011, 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 339 matching lines...) Expand 10 before | Expand all | Expand 10 after
350 // Media --------------------------------------------------------------- 350 // Media ---------------------------------------------------------------
351 351
352 // Performs the specified media player action on the node at the given locat ion. 352 // Performs the specified media player action on the node at the given locat ion.
353 virtual void performMediaPlayerAction( 353 virtual void performMediaPlayerAction(
354 const WebMediaPlayerAction&, const WebPoint& location) = 0; 354 const WebMediaPlayerAction&, const WebPoint& location) = 0;
355 355
356 // Performs the specified plugin action on the node at the given location. 356 // Performs the specified plugin action on the node at the given location.
357 virtual void performPluginAction( 357 virtual void performPluginAction(
358 const WebPluginAction&, const WebPoint& location) = 0; 358 const WebPluginAction&, const WebPoint& location) = 0;
359 359
360 // Notifies WebView about audio is started or stopped.
Sami 2016/10/03 14:36:32 s/about/when/?
altimin 2016/10/03 15:53:39 Done.
361 virtual void audioStateChanged(bool isAudioPlaying) = 0;
Sami 2016/10/03 14:36:32 nit: Could we be consistent about isAudioPlaying/i
altimin 2016/10/03 15:53:39 Sorry, it was the last typo in WebSchedulerImpl.
360 362
361 // Data exchange ------------------------------------------------------- 363 // Data exchange -------------------------------------------------------
362 364
363 // Do a hit test at given point and return the HitTestResult. 365 // Do a hit test at given point and return the HitTestResult.
364 virtual WebHitTestResult hitTestResultAt(const WebPoint&) = 0; 366 virtual WebHitTestResult hitTestResultAt(const WebPoint&) = 0;
365 367
366 // Do a hit test equivalent to what would be done for a GestureTap event 368 // Do a hit test equivalent to what would be done for a GestureTap event
367 // that has width/height corresponding to the supplied |tapArea|. 369 // that has width/height corresponding to the supplied |tapArea|.
368 virtual WebHitTestResult hitTestResultForTap(const WebPoint& tapPoint, 370 virtual WebHitTestResult hitTestResultForTap(const WebPoint& tapPoint,
369 const WebSize& tapArea) = 0; 371 const WebSize& tapArea) = 0;
(...skipping 158 matching lines...) Expand 10 before | Expand all | Expand 10 after
528 // completed. 530 // completed.
529 WebWidget* widget() { return this; } 531 WebWidget* widget() { return this; }
530 532
531 protected: 533 protected:
532 ~WebView() {} 534 ~WebView() {}
533 }; 535 };
534 536
535 } // namespace blink 537 } // namespace blink
536 538
537 #endif 539 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698