Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2383413002:
Add OriginTrial flag for Long Task Observer (Closed)
|
Created:
4 years, 2 months ago by panicker Modified:
4 years, 2 months ago CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd OriginTrial flag for Long Task Observer
BUG=635596
Committed: https://crrev.com/81f1adfdc5145e018c29a5bdbb2eeb11e1d20172
Cr-Commit-Position: refs/heads/master@{#422999}
Patch Set 1 #
Total comments: 2
Patch Set 2 : move origin trial check to Performance::updateLongTaskInstrumentation #
Total comments: 2
Patch Set 3 : sync, post blink reformat #Patch Set 4 : update expectation for layout test: global-interface-listing.html #Patch Set 5 : sync and rebase #
Messages
Total messages: 32 (18 generated)
panicker@chromium.org changed reviewers: + caseq@chromium.org
PTAL
lgtm https://codereview.chromium.org/2383413002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.cpp (right): https://codereview.chromium.org/2383413002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.cpp:49: if (!domWindow || !OriginTrials::longTaskObserverEnabled(domWindow->document())) Please consider moving the check to Performance::updateLongTaskInstrumentation(), this way we'll avoid creating the instance (or calling disable() on an instance that wasn't enabled).
panicker@chromium.org changed reviewers: + haraken@chromium.org
Kentaro, can you review for owners for platform/RuntimeEnabledFeatures.in? https://codereview.chromium.org/2383413002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.cpp (right): https://codereview.chromium.org/2383413002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.cpp:49: if (!domWindow || !OriginTrials::longTaskObserverEnabled(domWindow->document())) On 2016/10/03 18:12:04, caseq wrote: > Please consider moving the check to > Performance::updateLongTaskInstrumentation(), this way we'll avoid creating the > instance (or calling disable() on an instance that wasn't enabled). Done.
LGTM
chasej@chromium.org changed reviewers: + chasej@chromium.org
https://codereview.chromium.org/2383413002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.idl (right): https://codereview.chromium.org/2383413002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.idl:7: OriginTrialEnabled=LongTaskObserver, I see [RuntimeEnabled=LongTaskObserver] applied in Performance.idl: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/timing/Pe... I think those usages should be updated to use [OriginTrialEnabled] as well. Otherwise, the visibility will be inconsistent across the two when only the origin trial is enabled.
https://codereview.chromium.org/2383413002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.idl (right): https://codereview.chromium.org/2383413002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.idl:7: OriginTrialEnabled=LongTaskObserver, On 2016/10/04 03:30:09, chasej wrote: > I see [RuntimeEnabled=LongTaskObserver] applied in Performance.idl: > https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/timing/Pe... > > I think those usages should be updated to use [OriginTrialEnabled] as well. > Otherwise, the visibility will be inconsistent across the two when only the > origin trial is enabled. Those interfaces (in Performance.idl) are actually not in the spec, so it's on my list to remove them. Sending a CL right away. Thanks for the catch.
The CQ bit was checked by panicker@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org Link to the patchset: https://codereview.chromium.org/2383413002/#ps20001 (title: "move origin trial check to Performance::updateLongTaskInstrumentation")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by panicker@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by panicker@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org, caseq@chromium.org Link to the patchset: https://codereview.chromium.org/2383413002/#ps60001 (title: "update expectation for layout test: global-interface-listing.html")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by panicker@chromium.org
The CQ bit was checked by panicker@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by panicker@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org, caseq@chromium.org Link to the patchset: https://codereview.chromium.org/2383413002/#ps80001 (title: "sync and rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Add OriginTrial flag for Long Task Observer BUG=635596 ========== to ========== Add OriginTrial flag for Long Task Observer BUG=635596 Committed: https://crrev.com/81f1adfdc5145e018c29a5bdbb2eeb11e1d20172 Cr-Commit-Position: refs/heads/master@{#422999} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/81f1adfdc5145e018c29a5bdbb2eeb11e1d20172 Cr-Commit-Position: refs/heads/master@{#422999} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
