third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.idl - Issue 2383413002: Add OriginTrial flag for Long Task Observer

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.idl

Issue 2383413002: Add OriginTrial flag for Long Task Observer (Closed)

Patch Set: move origin trial check to Performance::updateLongTaskInstrumentation Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // https://github.com/spanicker/longtasks	5 // https://github.com/spanicker/longtasks

6 [	6 [

7 RuntimeEnabled=LongTaskObserver // Experimental flag	7 OriginTrialEnabled=LongTaskObserver,
	chasej 2016/10/04 03:30:09 I see [RuntimeEnabled=LongTaskObserver] applied in I see [RuntimeEnabled=LongTaskObserver] applied in Performance.idl: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/timing/Pe... I think those usages should be updated to use [OriginTrialEnabled] as well. Otherwise, the visibility will be inconsistent across the two when only the origin trial is enabled. panicker 2016/10/04 17:28:30 Those interfaces (in Performance.idl) are actually Show quoted text On 2016/10/04 03:30:09, chasej wrote: > I see [RuntimeEnabled=LongTaskObserver] applied in Performance.idl: > https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/timing/Pe... > > I think those usages should be updated to use [OriginTrialEnabled] as well. > Otherwise, the visibility will be inconsistent across the two when only the > origin trial is enabled. Those interfaces (in Performance.idl) are actually not in the spec, so it's on my list to remove them. Sending a CL right away. Thanks for the catch.
8 ] interface PerformanceLongTaskTiming : PerformanceEntry {	8 ] interface PerformanceLongTaskTiming : PerformanceEntry {

9 };	9 };

OLD	NEW