Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2383333002: Update shadowed data in MapBufferRange path. (Closed)

Created:
4 years, 2 months ago by Zhenyao Mo
Modified:
4 years, 2 months ago
CC:
chromium-reviews, piman+watch_chromium.org, vmiura, Kai Ninomiya
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update shadowed data in MapBufferRange path. Note that this path isn't accessable through WebGL2, but still a security threat that now we address in this CL. BUG=429053 TEST=gpu_unittests R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/da703a0fce4e56c2c56ff8a6ec95d38a6e8285b5 Cr-Commit-Position: refs/heads/master@{#422657}

Patch Set 1 #

Patch Set 2 : This should work #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -60 lines) Patch
M gpu/command_buffer/service/buffer_manager.h View 1 6 chunks +16 lines, -12 lines 0 comments Download
M gpu/command_buffer/service/buffer_manager.cc View 1 3 chunks +7 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 21 chunks +64 lines, -29 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_buffers.cc View 1 4 chunks +41 lines, -12 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (14 generated)
Zhenyao Mo
kbr: Please take a look. vmiura, kainino: FYI (feel free to also review)
4 years, 2 months ago (2016-10-03 23:12:09 UTC) #6
Ken Russell (switch to Gerrit)
Very nice. Excellent tests. LGTM
4 years, 2 months ago (2016-10-04 00:15:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383333002/80001
4 years, 2 months ago (2016-10-04 01:27:24 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:80001)
4 years, 2 months ago (2016-10-04 01:33:35 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 01:37:37 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/da703a0fce4e56c2c56ff8a6ec95d38a6e8285b5
Cr-Commit-Position: refs/heads/master@{#422657}

Powered by Google App Engine
This is Rietveld 408576698