DevTools: ConsoleViewMessage rewrite signatures to isolate formatting functions

DevTools: ConsoleViewMessage rewrite signatures to isolate formatting functions

This CL is obsolete, replaced by https://codereview.chromium.org/2397933005/

[luoe, 2016-09-30 21:31:29]

luoe@chromium.org changed reviewers:
+ lushnikov@chromium.org

[luoe, 2016-09-30 21:31:30]

luoe@chromium.org changed reviewers:
+ lushnikov@chromium.org

[lushnikov, 2016-09-30 21:56:46]

https://codereview.chromium.org/2383293002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
(right):

https://codereview.chromium.org/2383293002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:1248:
**/
let's not create an options object; instead, let's just pass arguments into the
functions

[luoe, 2016-10-01 01:10:52]

Instead of options object, how about a switch statement that calls each fn with
appropriate args?

https://codereview.chromium.org/2383293002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
(right):

https://codereview.chromium.org/2383293002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:1248:
**/
On 2016/09/30 21:56:46, lushnikov wrote:
> let's not create an options object; instead, let's just pass arguments into
the
> functions

Done.

https://codereview.chromium.org/2383293002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
(right):

https://codereview.chromium.org/2383293002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:503:
elem.className = type === "string" ? "source-code" : "object-value-" + type + "
source-code";
This is 'moved' from _formatParameterAsString() down below

[lushnikov, 2016-10-01 02:54:39]

i like the direction of the patch, but i feel that it's doing too much for a
single CL. Let's split it into parts so that nothing will slip behind our backs!

https://codereview.chromium.org/2383293002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
(right):

https://codereview.chromium.org/2383293002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:471:
var elem;
element

https://codereview.chromium.org/2383293002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:499:
default:
can we explicitly state them all? I feel uneasy because of this default!

https://codereview.chromium.org/2383293002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:503:
elem.className = type === "string" ? "source-code" : "object-value-" + type + "
source-code";
let's make every formatter to specify the classname explicitly

https://codereview.chromium.org/2383293002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:513:
var elem = createElement("span");
createElementWithClass("span", "object-value-...")

https://codereview.chromium.org/2383293002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:517:
return elem;
s/elem/element/gc

https://codereview.chromium.org/2383293002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:540:
_objectFormatterHelper: function(obj, linkifier, includePreview)
_formatRemoteObject:

https://codereview.chromium.org/2383293002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:612:
* @param {!WebInspector.RemoteObject} obj
object

https://codereview.chromium.org/2383293002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:618:
var elem = createElement("span");
element

https://codereview.chromium.org/2383293002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:701:
_printArrayResult: function(array, elem, linkifier, properties)
probably, you should create and return element here rather then accepting one
from the outer world

[luoe, 2016-10-10 21:48:46]

Description was changed from

==========
DevTools: ConsoleViewMessage rewrite signatures to isolate formatting functions
==========

to

==========
DevTools: ConsoleViewMessage rewrite signatures to isolate formatting functions

This CL is obsolete, replaced by https://codereview.chromium.org/2397933005/
==========