Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1391)

Issue 2373203002: DevTools: rename useArrayPreviewFormatter and remove ConsoleCommandResult override (Closed)

Created:
4 years, 2 months ago by luoe
Modified:
4 years, 2 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: rename useArrayPreviewFormatter and remove ConsoleCommandResult override This renames useArrayPreviewFormatter() to usePrintedArrayFormatter() and removes its override in ConsoleCommandResult Committed: https://crrev.com/b255e7d02cb6f7d6cdd9308a97c796323396cc06 Cr-Commit-Position: refs/heads/master@{#423000}

Patch Set 1 #

Total comments: 2

Patch Set 2 : make private #

Patch Set 3 : rebase/merge #

Patch Set 4 : rebase cl2patch6 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -15 lines) Patch
M third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js View 1 2 3 2 chunks +4 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 20 (14 generated)
luoe
4 years, 2 months ago (2016-09-28 01:08:43 UTC) #3
lushnikov
lgtm https://codereview.chromium.org/2373203002/diff/1/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js File third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js (right): https://codereview.chromium.org/2373203002/diff/1/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js#newcode592 third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:592: usePrintedArrayFormatter: function() can we make it private?
4 years, 2 months ago (2016-09-28 16:54:03 UTC) #4
luoe
https://codereview.chromium.org/2373203002/diff/1/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js File third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js (right): https://codereview.chromium.org/2373203002/diff/1/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js#newcode592 third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:592: usePrintedArrayFormatter: function() On 2016/09/28 16:54:03, lushnikov wrote: > can ...
4 years, 2 months ago (2016-09-28 17:50:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373203002/60001
4 years, 2 months ago (2016-10-04 23:31:03 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-10-04 23:36:49 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 23:38:29 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b255e7d02cb6f7d6cdd9308a97c796323396cc06
Cr-Commit-Position: refs/heads/master@{#423000}

Powered by Google App Engine
This is Rietveld 408576698