Fix reading of password values.

Fix reading of password values.

Chrome exposes passwords using bullets (\u2022). Add this to the repetition regex which gets used to replace multiple occurances with an internationalized formatted string like
1 dot
2 dots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
BUG=647092
Committed: https://crrev.com/5723dd766de19a0acbc14b740d702ae71de61485
Cr-Commit-Position: refs/heads/master@{#422252}

[David Tseng, 2016-09-30 18:40:41]

Description was changed from

==========
Fix reading of password values.
==========

to

==========
Fix reading of password values.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-09-30 18:43:10]

Description was changed from

==========
Fix reading of password values.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix reading of password values.

Chrome exposes passwords using bullets (\u2022). Add this to the repetition
regex which gets used to replace multiple occurances with an internationalized
formatted string like
1 dot
2 dots


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
BUG=647092
==========

[David Tseng, 2016-09-30 18:43:10]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2016-09-30 18:47:05]

Fix lgtm but a couple of important issues below

https://codereview.chromium.org/2383173002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd
(right):

https://codereview.chromium.org/2383173002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd:2170:
{COUNT, plural, =1 {exclaimation}other {# exclaimations}}
This is misspelled now, should be exclamation

https://codereview.chromium.org/2383173002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd:2271:
<message desc="BULLET (•) character description." name="IDS_CHROMEVOX_BULLET">
I'd clarify that this is in the context of a password, and maybe have a separate
string for other cases, otherwise list items will announce dot instead of bullet

Alternatively, would it be so bad to say "bullet" or "8 bullets"?

[David Tseng, 2016-09-30 19:00:12]

https://codereview.chromium.org/2383173002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd
(right):

https://codereview.chromium.org/2383173002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd:2170:
{COUNT, plural, =1 {exclaimation}other {# exclaimations}}
On 2016/09/30 18:47:04, dmazzoni wrote:
> This is misspelled now, should be exclamation

Good catch; had shortened it to exclaim/exclaims...but changed it after
reviewing other srs.

https://codereview.chromium.org/2383173002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd:2271:
<message desc="BULLET (•) character description." name="IDS_CHROMEVOX_BULLET">
On 2016/09/30 18:47:04, dmazzoni wrote:
> I'd clarify that this is in the context of a password, and maybe have a
separate
> string for other cases, otherwise list items will announce dot instead of
bullet
> 
> Alternatively, would it be so bad to say "bullet" or "8 bullets"?

Bullet is fine; we'll just have to use it everywhere including editable text
(for typing echo).

[David Tseng, 2016-09-30 19:00:45]

The CQ bit was checked by dtseng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 19:01:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 20:04:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 20:04:38]

Dry run: This issue passed the CQ dry run.

[David Tseng, 2016-09-30 22:43:58]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-09-30 22:43:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2383173002/#ps20001
(title: "Bullets everywhere")

[commit-bot: I haz the power, 2016-09-30 22:44:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 22:50:39]

Description was changed from

==========
Fix reading of password values.

Chrome exposes passwords using bullets (\u2022). Add this to the repetition
regex which gets used to replace multiple occurances with an internationalized
formatted string like
1 dot
2 dots


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
BUG=647092
==========

to

==========
Fix reading of password values.

Chrome exposes passwords using bullets (\u2022). Add this to the repetition
regex which gets used to replace multiple occurances with an internationalized
formatted string like
1 dot
2 dots


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
BUG=647092
==========

[commit-bot: I haz the power, 2016-09-30 22:50:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-30 22:53:49]

Description was changed from

==========
Fix reading of password values.

Chrome exposes passwords using bullets (\u2022). Add this to the repetition
regex which gets used to replace multiple occurances with an internationalized
formatted string like
1 dot
2 dots


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
BUG=647092
==========

to

==========
Fix reading of password values.

Chrome exposes passwords using bullets (\u2022). Add this to the repetition
regex which gets used to replace multiple occurances with an internationalized
formatted string like
1 dot
2 dots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
BUG=647092

Committed: https://crrev.com/5723dd766de19a0acbc14b740d702ae71de61485
Cr-Commit-Position: refs/heads/master@{#422252}
==========

[commit-bot: I haz the power, 2016-09-30 22:53:51]

Patchset 2 (id:??) landed as
https://crrev.com/5723dd766de19a0acbc14b740d702ae71de61485
Cr-Commit-Position: refs/heads/master@{#422252}