third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp - Issue 2383113003: Refactor ScrollableArea::setScrollPosition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp

Issue 2383113003: Refactor ScrollableArea::setScrollPosition. (Closed)

Patch Set: Fix clamping, comment tweaks Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp ('K') | « third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp ('k') | third_party/WebKit/Source/platform/scroll/ScrollableArea.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp

diff --git a/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp b/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp

index cbb3ddb9ca509b6c63da7f21edbdbf1a0d082bb1..cdcd67ae22fcd6bc9ab4c1ce8fbe4604f50359b2 100644

--- a/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp

+++ b/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp

@@ -291,8 +291,7 @@ void ScrollAnimatorCompositorCoordinator::adjustAnimationAndSetScrollPosition(

const DoublePoint& position,

ScrollType scrollType) {

// Subclasses should override this and adjust the animation as necessary.

- DoublePoint adjustedPos = getScrollableArea()->clampScrollPosition(position);

- scrollPositionChanged(adjustedPos, scrollType);

+ scrollPositionChanged(position, scrollType);

}

void ScrollAnimatorCompositorCoordinator::adjustImplOnlyScrollOffsetAnimation(