Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1399)

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp

Issue 2383113003: Refactor ScrollableArea::setScrollPosition. (Closed)
Patch Set: Fix clamping, comment tweaks Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp
diff --git a/third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp b/third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp
index c3a8ee7654bd0bca004dc39b7b379819346a1622..28bde3e9328496d5b7242b814873f0fa7d321157 100644
--- a/third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp
+++ b/third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp
@@ -190,12 +190,11 @@ bool ScrollAnimator::willAnimateToOffset(const FloatPoint& targetPos) {
void ScrollAnimator::adjustAnimationAndSetScrollPosition(
const DoublePoint& position,
ScrollType scrollType) {
- DoublePoint adjustedPos = m_scrollableArea->clampScrollPosition(position);
IntSize actualAdjustment =
skobes 2016/10/04 22:25:26 Rename this to "adjustment" (the "actual" part mak
szager1 2016/10/04 22:54:14 Done.
- roundedIntPoint(adjustedPos) -
+ roundedIntPoint(position) -
roundedIntPoint(m_scrollableArea->scrollPositionDouble());
- scrollPositionChanged(adjustedPos, scrollType);
+ scrollPositionChanged(position, scrollType);
if (m_runState == RunState::Idle) {
adjustImplOnlyScrollOffsetAnimation(actualAdjustment);

Powered by Google App Engine
This is Rietveld 408576698