Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Issue 2383003004: Use FileDescriptorWatcher in DeviceMonitorLinux (Closed)

Created:
4 years, 2 months ago by fdoray
Modified:
4 years, 2 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use FileDescriptorWatcher in DeviceMonitorLinux This allows DeviceMonitorLinux to be used from any thread that instantiates a FileDescriptorWatcher (not just threads that run a MessageLoopForIO). This will facilitate the migration of BrowserThreads to base/task_scheduler. BUG=645114 Committed: https://crrev.com/47b8d1585acb01b51f99ce4ab106eb123f9d2502 Cr-Commit-Position: refs/heads/master@{#422456}

Patch Set 1 #

Patch Set 2 : fix test error #

Patch Set 3 : remove unused include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -26 lines) Patch
M device/core/device_monitor_linux.h View 1 2 3 chunks +7 lines, -10 lines 0 comments Download
M device/core/device_monitor_linux.cc View 4 chunks +12 lines, -16 lines 0 comments Download
M device/hid/input_service_linux_unittest.cc View 1 2 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
fdoray
PTAL
4 years, 2 months ago (2016-10-03 15:07:07 UTC) #10
Ken Rockot(use gerrit already)
lgtm
4 years, 2 months ago (2016-10-03 17:46:17 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383003004/40001
4 years, 2 months ago (2016-10-03 17:49:06 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-03 17:54:39 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 17:58:01 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/47b8d1585acb01b51f99ce4ab106eb123f9d2502
Cr-Commit-Position: refs/heads/master@{#422456}

Powered by Google App Engine
This is Rietveld 408576698