Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: device/core/device_monitor_linux.h

Issue 2383003004: Use FileDescriptorWatcher in DeviceMonitorLinux (Closed)
Patch Set: remove unused include Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | device/core/device_monitor_linux.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef DEVICE_HID_DEVICE_MONITOR_LINUX_H_ 5 #ifndef DEVICE_HID_DEVICE_MONITOR_LINUX_H_
6 #define DEVICE_HID_DEVICE_MONITOR_LINUX_H_ 6 #define DEVICE_HID_DEVICE_MONITOR_LINUX_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <string> 9 #include <string>
10 10
11 #include "base/compiler_specific.h" 11 #include "base/compiler_specific.h"
12 #include "base/files/file_descriptor_watcher_posix.h"
12 #include "base/macros.h" 13 #include "base/macros.h"
13 #include "base/message_loop/message_loop.h" 14 #include "base/message_loop/message_loop.h"
14 #include "base/message_loop/message_pump_libevent.h"
15 #include "base/observer_list.h" 15 #include "base/observer_list.h"
16 #include "base/threading/thread_checker.h" 16 #include "base/threading/thread_checker.h"
17 #include "device/core/device_core_export.h" 17 #include "device/core/device_core_export.h"
18 #include "device/udev_linux/scoped_udev.h" 18 #include "device/udev_linux/scoped_udev.h"
19 19
20 struct udev_device; 20 struct udev_device;
21 21
22 namespace device { 22 namespace device {
23 23
24 // This class listends for notifications from libudev about 24 // This class listends for notifications from libudev about
25 // connected/disconnected devices. This class is *NOT* thread-safe and 25 // connected/disconnected devices. This class is *NOT* thread-safe.
26 // all methods must be accessed from the FILE thread.
27 class DEVICE_CORE_EXPORT DeviceMonitorLinux 26 class DEVICE_CORE_EXPORT DeviceMonitorLinux
28 : public base::MessageLoop::DestructionObserver, 27 : public base::MessageLoop::DestructionObserver {
29 public base::MessagePumpLibevent::Watcher {
30 public: 28 public:
31 typedef base::Callback<void(udev_device* device)> EnumerateCallback; 29 typedef base::Callback<void(udev_device* device)> EnumerateCallback;
32 30
33 class Observer { 31 class Observer {
34 public: 32 public:
35 virtual ~Observer() {} 33 virtual ~Observer() {}
36 virtual void OnDeviceAdded(udev_device* device) = 0; 34 virtual void OnDeviceAdded(udev_device* device) = 0;
37 virtual void OnDeviceRemoved(udev_device* device) = 0; 35 virtual void OnDeviceRemoved(udev_device* device) = 0;
38 virtual void WillDestroyMonitorMessageLoop() = 0; 36 virtual void WillDestroyMonitorMessageLoop() = 0;
39 }; 37 };
40 38
41 DeviceMonitorLinux(); 39 DeviceMonitorLinux();
42 40
43 static DeviceMonitorLinux* GetInstance(); 41 static DeviceMonitorLinux* GetInstance();
44 42
45 void AddObserver(Observer* observer); 43 void AddObserver(Observer* observer);
46 void RemoveObserver(Observer* observer); 44 void RemoveObserver(Observer* observer);
47 45
48 ScopedUdevDevicePtr GetDeviceFromPath(const std::string& path); 46 ScopedUdevDevicePtr GetDeviceFromPath(const std::string& path);
49 void Enumerate(const EnumerateCallback& callback); 47 void Enumerate(const EnumerateCallback& callback);
50 48
51 // Implements base::MessageLoop::DestructionObserver 49 // Implements base::MessageLoop::DestructionObserver
52 void WillDestroyCurrentMessageLoop() override; 50 void WillDestroyCurrentMessageLoop() override;
53 51
54 // Implements base::MessagePumpLibevent::Watcher
55 void OnFileCanReadWithoutBlocking(int fd) override;
56 void OnFileCanWriteWithoutBlocking(int fd) override;
57
58 private: 52 private:
59 friend std::default_delete<DeviceMonitorLinux>; 53 friend std::default_delete<DeviceMonitorLinux>;
60 54
61 ~DeviceMonitorLinux() override; 55 ~DeviceMonitorLinux() override;
62 56
57 void OnMonitorCanReadWithoutBlocking();
58
63 ScopedUdevPtr udev_; 59 ScopedUdevPtr udev_;
64 ScopedUdevMonitorPtr monitor_; 60 ScopedUdevMonitorPtr monitor_;
65 int monitor_fd_; 61 int monitor_fd_;
66 base::MessagePumpLibevent::FileDescriptorWatcher monitor_watcher_; 62 std::unique_ptr<base::FileDescriptorWatcher::Controller>
63 monitor_watch_controller_;
67 64
68 base::ObserverList<Observer, true> observers_; 65 base::ObserverList<Observer, true> observers_;
69 66
70 base::ThreadChecker thread_checker_; 67 base::ThreadChecker thread_checker_;
71 68
72 DISALLOW_COPY_AND_ASSIGN(DeviceMonitorLinux); 69 DISALLOW_COPY_AND_ASSIGN(DeviceMonitorLinux);
73 }; 70 };
74 71
75 } // namespace device 72 } // namespace device
76 73
77 #endif // DEVICE_HID_DEVICE_MONITOR_LINUX_H_ 74 #endif // DEVICE_HID_DEVICE_MONITOR_LINUX_H_
OLDNEW
« no previous file with comments | « no previous file | device/core/device_monitor_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698