Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 23830009: Deletes bench_expectations.txt and change comments to refer to the new per-bot expectation files. (Closed)

Created:
7 years, 3 months ago by benchen
Modified:
7 years, 2 months ago
Reviewers:
borenet
CC:
skia-review_googlegroups.com, skiabot_google.com
Visibility:
Public.

Description

Deletes bench_expectations.txt and change comments to refer to the new per-bot expectation files. Committed: https://code.google.com/p/skia/source/detail?r=11456

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2184 lines) Patch
D bench/bench_expectations.txt View 1 chunk +0 lines, -2176 lines 0 comments Download
M bench/bench_graph_svg.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M bench/gen_bench_ranges.py View 1 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
benchen
will submit after tree goes green. Thanks.
7 years, 3 months ago (2013-09-23 19:16:59 UTC) #1
borenet
LGTM with suggestion https://codereview.chromium.org/23830009/diff/1/bench/bench_graph_svg.py File bench/bench_graph_svg.py (right): https://codereview.chromium.org/23830009/diff/1/bench/bench_graph_svg.py#newcode37 bench/bench_graph_svg.py:37: print ' See bench_expectations_<bot>.txt for data ...
7 years, 3 months ago (2013-09-23 19:27:14 UTC) #2
benchen
changed bot to builder. Thx. https://codereview.chromium.org/23830009/diff/1/bench/bench_graph_svg.py File bench/bench_graph_svg.py (right): https://codereview.chromium.org/23830009/diff/1/bench/bench_graph_svg.py#newcode37 bench/bench_graph_svg.py:37: print ' See bench_expectations_<bot>.txt ...
7 years, 3 months ago (2013-09-23 19:33:25 UTC) #3
benchen
7 years, 2 months ago (2013-09-25 20:51:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r11456 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698