Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1400)

Unified Diff: bench/gen_bench_ranges.py

Issue 23830009: Deletes bench_expectations.txt and change comments to refer to the new per-bot expectation files. (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « bench/bench_graph_svg.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: bench/gen_bench_ranges.py
===================================================================
--- bench/gen_bench_ranges.py (revision 11440)
+++ bench/gen_bench_ranges.py (working copy)
@@ -5,13 +5,13 @@
""" Analyze recent SkPicture or Microbench data, and output suggested ranges.
-The outputs can be edited and pasted to bench_expectations.txt to trigger
-buildbot alerts if the actual benches are out of range. Details are documented
-in the .txt file.
+The outputs can be edited and pasted to bench_expectations_<builder>.txt to
+trigger buildbot alerts if the actual benches are out of range. Details are
+documented in the corresponding .txt file for each builder.
-Currently the easiest way to batch update bench_expectations.txt is to delete
-all bench lines, run this script, and redirect outputs (">>") to be added to the
-.txt file.
+Currently the easiest way to batch update bench_expectations_<builder>.txt is to
+delete all bench lines, run this script, and redirect outputs (">>") to be added
+to the corresponding .txt file for each perf builder.
You can also just manually change a few lines of interest, of course.
Note: since input data are stored in Google Storage, you will need to set up
« no previous file with comments | « bench/bench_graph_svg.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698