Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1618)

Unified Diff: runtime/vm/code_patcher_x64.cc

Issue 2382953004: Revert "Lazy deopt without code patching." (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/code_patcher_mips.cc ('k') | runtime/vm/deopt_instructions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_patcher_x64.cc
diff --git a/runtime/vm/code_patcher_x64.cc b/runtime/vm/code_patcher_x64.cc
index 8e3e8898fd99f5bc7c35c912241310cabefa1f6e..0e18f6f046672c96a3ed6ce8403c38999f1e7616 100644
--- a/runtime/vm/code_patcher_x64.cc
+++ b/runtime/vm/code_patcher_x64.cc
@@ -293,8 +293,13 @@ intptr_t CodePatcher::InstanceCallSizeInBytes() {
}
-void CodePatcher::InsertDeoptimizationCallAt(uword start) {
- UNREACHABLE();
+void CodePatcher::InsertDeoptimizationCallAt(uword start, uword target) {
+ // The inserted call should not overlap the lazy deopt jump code.
+ ASSERT(start + ShortCallPattern::pattern_length_in_bytes() <= target);
+ *reinterpret_cast<uint8_t*>(start) = 0xE8;
+ ShortCallPattern call(start);
+ call.SetTargetAddress(target);
+ CPU::FlushICache(start, ShortCallPattern::pattern_length_in_bytes());
}
« no previous file with comments | « runtime/vm/code_patcher_mips.cc ('k') | runtime/vm/deopt_instructions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698