Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: runtime/vm/code_patcher_mips.cc

Issue 2382953004: Revert "Lazy deopt without code patching." (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/code_patcher_ia32.cc ('k') | runtime/vm/code_patcher_x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_patcher_mips.cc
diff --git a/runtime/vm/code_patcher_mips.cc b/runtime/vm/code_patcher_mips.cc
index 3ed9af34da4f6d63ed6c95af3b3ebd461b53aa0e..a4d0433a09944eae1a17eb3e4eb000b70f30b76e 100644
--- a/runtime/vm/code_patcher_mips.cc
+++ b/runtime/vm/code_patcher_mips.cc
@@ -29,8 +29,10 @@ void CodePatcher::PatchStaticCallAt(uword return_address,
}
-void CodePatcher::InsertDeoptimizationCallAt(uword start) {
- UNREACHABLE();
+void CodePatcher::InsertDeoptimizationCallAt(uword start, uword target) {
+ // The inserted call should not overlap the lazy deopt jump code.
+ ASSERT(start + CallPattern::kDeoptCallLengthInBytes <= target);
+ CallPattern::InsertDeoptCallAt(start, target);
}
« no previous file with comments | « runtime/vm/code_patcher_ia32.cc ('k') | runtime/vm/code_patcher_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698