Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Side by Side Diff: runtime/vm/code_patcher_mips.cc

Issue 2382953004: Revert "Lazy deopt without code patching." (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/code_patcher_ia32.cc ('k') | runtime/vm/code_patcher_x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_MIPS. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_MIPS.
6 #if defined(TARGET_ARCH_MIPS) 6 #if defined(TARGET_ARCH_MIPS)
7 7
8 #include "vm/code_patcher.h" 8 #include "vm/code_patcher.h"
9 9
10 #include "vm/instructions.h" 10 #include "vm/instructions.h"
(...skipping 11 matching lines...) Expand all
22 22
23 void CodePatcher::PatchStaticCallAt(uword return_address, 23 void CodePatcher::PatchStaticCallAt(uword return_address,
24 const Code& code, 24 const Code& code,
25 const Code& new_target) { 25 const Code& new_target) {
26 ASSERT(code.ContainsInstructionAt(return_address)); 26 ASSERT(code.ContainsInstructionAt(return_address));
27 CallPattern call(return_address, code); 27 CallPattern call(return_address, code);
28 call.SetTargetCode(new_target); 28 call.SetTargetCode(new_target);
29 } 29 }
30 30
31 31
32 void CodePatcher::InsertDeoptimizationCallAt(uword start) { 32 void CodePatcher::InsertDeoptimizationCallAt(uword start, uword target) {
33 UNREACHABLE(); 33 // The inserted call should not overlap the lazy deopt jump code.
34 ASSERT(start + CallPattern::kDeoptCallLengthInBytes <= target);
35 CallPattern::InsertDeoptCallAt(start, target);
34 } 36 }
35 37
36 38
37 RawCode* CodePatcher::GetInstanceCallAt(uword return_address, 39 RawCode* CodePatcher::GetInstanceCallAt(uword return_address,
38 const Code& code, 40 const Code& code,
39 ICData* ic_data) { 41 ICData* ic_data) {
40 ASSERT(code.ContainsInstructionAt(return_address)); 42 ASSERT(code.ContainsInstructionAt(return_address));
41 CallPattern call(return_address, code); 43 CallPattern call(return_address, code);
42 if (ic_data != NULL) { 44 if (ic_data != NULL) {
43 *ic_data = call.IcData(); 45 *ic_data = call.IcData();
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 NativeFunction* target) { 111 NativeFunction* target) {
110 ASSERT(code.ContainsInstructionAt(return_address)); 112 ASSERT(code.ContainsInstructionAt(return_address));
111 NativeCallPattern call(return_address, code); 113 NativeCallPattern call(return_address, code);
112 *target = call.native_function(); 114 *target = call.native_function();
113 return call.target(); 115 return call.target();
114 } 116 }
115 117
116 } // namespace dart 118 } // namespace dart
117 119
118 #endif // defined TARGET_ARCH_MIPS 120 #endif // defined TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « runtime/vm/code_patcher_ia32.cc ('k') | runtime/vm/code_patcher_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698