Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2382913003: Revert of Fix scroll chaining for non-descendants of root scroller. (Closed)

Created:
4 years, 2 months ago by bokan
Modified:
4 years, 2 months ago
CC:
blink-reviews, cc-bugs_chromium.org, chromium-reviews, dtapuska+blinkwatch_chromium.org, nzolghadr+blinkwatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix scroll chaining for non-descendants of root scroller. (patchset #4 id:60001 of https://codereview.chromium.org/2365793002/ ) Reason for revert: Broke WebView scrolling. See crbug.com/651515 Original issue's description: > Fix scroll chaining for non-descendants of root scroller. > > This CL fixes the scroll chaining behavior for elements that aren't descendants > of the root scroller element. This can only happen in the non-document root > scroller proposal. > > On the main thread scrolling path, we were previously assuming that all scrolls > would chain through the effective root scroller. This CL fixes the terminating > condition as well as removes an invalid DCHECK. > > On the compositor side, the chaining mechanisms would previously use the inner > viewport scroll layer to designate viewport scrolling. Further on, we would > explicitly check for the inner viewport layer and scroll using cc::Viewport. > When scrolling a non-descendant of the root scroller, we chain up to the inner > viewport scroll layer without going through the outer viewport. Scrolling > cc::Viewport causes scrolling in the outer viewport though so we would scroll > it inadvertaintly. I've made changes so that we use the outer viewport to > designate cc::Viewport scrolling. Scrolls will terminate at the outer viewport > scroll layer, but they don't have to chain through it. > > Unrelated, but I also removed LayerImpl::ApplyScroll as it's unused. > > BUG=505516 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > Committed: https://crrev.com/bc48cb30d9e473b693dc996b7750510d05d50f69 > Cr-Commit-Position: refs/heads/master@{#420763} TBR=aelias@chromium.org,jaydasika@chromium.org,tdresser@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=505516 Committed: https://crrev.com/29bd015dd8bff8eb77bbd687b7135e45061c021f Cr-Commit-Position: refs/heads/master@{#422152}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -361 lines) Patch
M cc/layers/layer_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/layer_impl.cc View 1 chunk +8 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 7 chunks +22 lines, -16 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 11 chunks +33 lines, -229 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/scrolling/scroll-non-descendant-of-root-scroller.html View 1 chunk +0 lines, -111 lines 0 comments Download
M third_party/WebKit/Source/core/input/ScrollManager.cpp View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
bokan
Created Revert of Fix scroll chaining for non-descendants of root scroller.
4 years, 2 months ago (2016-09-30 16:05:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2382913003/1
4 years, 2 months ago (2016-09-30 16:05:20 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-30 18:04:03 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 18:05:55 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/29bd015dd8bff8eb77bbd687b7135e45061c021f
Cr-Commit-Position: refs/heads/master@{#422152}

Powered by Google App Engine
This is Rietveld 408576698