Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2382833002: Rename policy::EnterpriseInstallAttributes to chromeos::InstallAttributes. (Closed)

Created:
4 years, 2 months ago by Thiemo Nagel
Modified:
4 years, 2 months ago
Reviewers:
emaxx
CC:
chromium-reviews, dbeam+watch-options_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, alemate+watch_chromium.org, hashimoto+watch_chromium.org, achuith+watch_chromium.org, dkrahn+watch_chromium.org, michaelpg+watch-options_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename policy::EnterpriseInstallAttributes to chromeos::InstallAttributes. Also replace some bare "new" with MakeUnique in BrowserPolicyConnectorChromeOS. BUG=249513 TBR=achuith (chrome/browser/chromeos) TBR=asargent (chrome/browser/extensions) TBR=eroman (chrome/browser/net) TBR=bauerb (chrome/browser/ui/webui) TBR=hashimoto (chromeos/dbus) Committed: https://crrev.com/0168d092ea22abedda343c5e9d806ee592f5d881 Cr-Commit-Position: refs/heads/master@{#422095}

Patch Set 1 #

Patch Set 2 : Replace a some bare "new"s by MakeUnique. #

Patch Set 3 : Minor polish. #

Patch Set 4 : Add missing #includes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+445 lines, -1555 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/BUILD.gn View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_app_manager.h View 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_app_manager.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_app_manager_browsertest.cc View 1 2 3 4 chunks +10 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/affiliated_invalidation_service_provider_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/blocking_login_browsertest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h View 5 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc View 1 10 chunks +33 lines, -30 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_initializer.h View 4 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_initializer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.h View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos_unittest.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/policy/device_policy_cros_browser_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/device_status_collector_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/enrollment_handler_chromeos.h View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc View 3 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/policy/enrollment_status_chromeos.h View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/policy/enrollment_status_chromeos.cc View 8 chunks +9 lines, -9 lines 0 comments Download
D chrome/browser/chromeos/policy/enterprise_install_attributes.h View 1 chunk +0 lines, -200 lines 0 comments Download
D chrome/browser/chromeos/policy/enterprise_install_attributes.cc View 1 chunk +0 lines, -513 lines 0 comments Download
D chrome/browser/chromeos/policy/enterprise_install_attributes_unittest.cc View 1 chunk +0 lines, -283 lines 0 comments Download
M chrome/browser/chromeos/policy/heartbeat_scheduler.h View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/chromeos/policy/stub_enterprise_install_attributes.h View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/chromeos/policy/stub_enterprise_install_attributes.cc View 1 chunk +0 lines, -55 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
A + chrome/browser/chromeos/settings/install_attributes.h View 8 chunks +35 lines, -43 lines 0 comments Download
A + chrome/browser/chromeos/settings/install_attributes.cc View 1 2 18 chunks +98 lines, -112 lines 0 comments Download
A + chrome/browser/chromeos/settings/install_attributes_unittest.cc View 1 2 3 8 chunks +78 lines, -75 lines 0 comments Download
A + chrome/browser/chromeos/settings/stub_install_attributes.h View 1 1 chunk +17 lines, -17 lines 0 comments Download
A + chrome/browser/chromeos/settings/stub_install_attributes.cc View 1 2 1 chunk +15 lines, -18 lines 0 comments Download
M chrome/browser/chromeos/system/device_disabling_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system/device_disabling_manager_unittest.cc View 4 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_apitest.cc View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.h View 5 chunks +5 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/identity/identity_apitest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/net/errorpage_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/options/preferences_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chromeos/dbus/fake_cryptohome_client.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (14 generated)
Thiemo Nagel
Hi Maksim, could you please take a look? Thank you, Thiemo
4 years, 2 months ago (2016-09-29 18:05:09 UTC) #5
emaxx
lgtm
4 years, 2 months ago (2016-09-29 19:51:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2382833002/60001
4 years, 2 months ago (2016-09-30 13:11:22 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-09-30 13:17:17 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 13:20:34 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/0168d092ea22abedda343c5e9d806ee592f5d881
Cr-Commit-Position: refs/heads/master@{#422095}

Powered by Google App Engine
This is Rietveld 408576698