Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1517)

Issue 238273010: Don't check if SerializedScriptValue's Reader::m_version is less than 0 (Closed)

Created:
6 years, 8 months ago by Inactive
Modified:
6 years, 8 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), arv+blink, jsbell+bindings_chromium.org, sof, kouhei+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive
Visibility:
Public.

Description

Don't check if SerializedScriptValue's Reader::m_version is less than 0 Don't check if SerializedScriptValue's Reader::m_version is less than 0 as the variable is unsigned. R=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171827

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M Source/bindings/v8/SerializedScriptValue.cpp View 8 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
6 years, 8 months ago (2014-04-17 01:31:52 UTC) #1
haraken
m_version is uint32_t, so it shouldn't become negative. LGTM.
6 years, 8 months ago (2014-04-17 01:34:00 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 8 months ago (2014-04-17 01:47:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/238273010/1
6 years, 8 months ago (2014-04-17 01:47:47 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-17 02:32:00 UTC) #5
Message was sent while issue was closed.
Change committed as 171827

Powered by Google App Engine
This is Rietveld 408576698