Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: Source/bindings/v8/SerializedScriptValue.cpp

Issue 238273010: Don't check if SerializedScriptValue's Reader::m_version is less than 0 (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/SerializedScriptValue.cpp
diff --git a/Source/bindings/v8/SerializedScriptValue.cpp b/Source/bindings/v8/SerializedScriptValue.cpp
index 1344a815dfc1072edbd85bc26b56b2a60f35340b..a2d50c985f8de4245d6605b572fcd67802e6e264 100644
--- a/Source/bindings/v8/SerializedScriptValue.cpp
+++ b/Source/bindings/v8/SerializedScriptValue.cpp
@@ -1637,7 +1637,7 @@ public:
return false;
switch (tag) {
case ReferenceCountTag: {
- if (m_version <= 0)
+ if (!m_version)
return false;
uint32_t referenceTableSize;
if (!doReadUint32(&referenceTableSize))
@@ -1778,7 +1778,7 @@ public:
break;
}
case ArrayBufferViewTag: {
- if (m_version <= 0)
+ if (!m_version)
return false;
if (!readArrayBufferView(value, creator))
return false;
@@ -1786,7 +1786,7 @@ public:
break;
}
case ArrayBufferTag: {
- if (m_version <= 0)
+ if (!m_version)
return false;
if (!readArrayBuffer(value))
return false;
@@ -1794,14 +1794,14 @@ public:
break;
}
case GenerateFreshObjectTag: {
- if (m_version <= 0)
+ if (!m_version)
return false;
if (!creator.newObject())
return false;
return true;
}
case GenerateFreshSparseArrayTag: {
- if (m_version <= 0)
+ if (!m_version)
return false;
uint32_t length;
if (!doReadUint32(&length))
@@ -1811,7 +1811,7 @@ public:
return true;
}
case GenerateFreshDenseArrayTag: {
- if (m_version <= 0)
+ if (!m_version)
return false;
uint32_t length;
if (!doReadUint32(&length))
@@ -1821,7 +1821,7 @@ public:
return true;
}
case MessagePortTag: {
- if (m_version <= 0)
+ if (!m_version)
return false;
uint32_t index;
if (!doReadUint32(&index))
@@ -1831,7 +1831,7 @@ public:
break;
}
case ArrayBufferTransferTag: {
- if (m_version <= 0)
+ if (!m_version)
return false;
uint32_t index;
if (!doReadUint32(&index))
@@ -1841,7 +1841,7 @@ public:
break;
}
case ObjectReferenceTag: {
- if (m_version <= 0)
+ if (!m_version)
return false;
uint32_t reference;
if (!doReadUint32(&reference))
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698